From bda394e8e30f27064fda5f86ce48e4d223ffc186 Mon Sep 17 00:00:00 2001
From: Hariom Verma <hariom.verma@tendermint.com>
Date: Wed, 8 Nov 2023 15:48:21 +0530
Subject: [PATCH] chore(gnomod): test package does not exist (#1317)

Add test for package does not exist.

Not able to reproduce `Infinite loop when a requested package does not
exist` (#835)
---
 gnovm/pkg/gnomod/file_test.go | 60 ++++++++++++++++++++++++-----------
 1 file changed, 42 insertions(+), 18 deletions(-)

diff --git a/gnovm/pkg/gnomod/file_test.go b/gnovm/pkg/gnomod/file_test.go
index 7acea3a6096..0012960eb4f 100644
--- a/gnovm/pkg/gnomod/file_test.go
+++ b/gnovm/pkg/gnomod/file_test.go
@@ -20,11 +20,30 @@ func TestFetchDeps(t *testing.T) {
 	for _, tc := range []struct {
 		desc                 string
 		modFile              File
+		errorShouldContain   string
 		requirements         []string
 		stdOutContains       []string
 		cachedStdOutContains []string
 	}{
 		{
+			desc: "not_exists",
+			modFile: File{
+				Module: &modfile.Module{
+					Mod: module.Version{
+						Path: "testFetchDeps",
+					},
+				},
+				Require: []*modfile.Require{
+					{
+						Mod: module.Version{
+							Path:    "gno.land/p/demo/does_not_exists",
+							Version: "v0.0.0",
+						},
+					},
+				},
+			},
+			errorShouldContain: "querychain (gno.land/p/demo/does_not_exists)",
+		}, {
 			desc: "fetch_gno.land/p/demo/avl",
 			modFile: File{
 				Module: &modfile.Module{
@@ -89,29 +108,34 @@ func TestFetchDeps(t *testing.T) {
 			defer cleanUpFn()
 
 			// Fetching dependencies
-			tc.modFile.FetchDeps(dirPath, testRemote, true)
+			err := tc.modFile.FetchDeps(dirPath, testRemote, true)
+			if tc.errorShouldContain != "" {
+				require.ErrorContains(t, err, tc.errorShouldContain)
+			} else {
+				require.Nil(t, err)
 
-			// Read dir
-			entries, err := os.ReadDir(filepath.Join(dirPath, "gno.land", "p", "demo"))
-			require.Nil(t, err)
+				// Read dir
+				entries, err := os.ReadDir(filepath.Join(dirPath, "gno.land", "p", "demo"))
+				require.Nil(t, err)
 
-			// Check dir entries
-			assert.Equal(t, len(tc.requirements), len(entries))
-			for _, e := range entries {
-				assert.Contains(t, tc.requirements, e.Name())
-			}
+				// Check dir entries
+				assert.Equal(t, len(tc.requirements), len(entries))
+				for _, e := range entries {
+					assert.Contains(t, tc.requirements, e.Name())
+				}
 
-			// Check logs
-			for _, c := range tc.stdOutContains {
-				assert.Contains(t, buf.String(), c)
-			}
+				// Check logs
+				for _, c := range tc.stdOutContains {
+					assert.Contains(t, buf.String(), c)
+				}
 
-			buf.Reset()
+				buf.Reset()
 
-			// Try fetching again. Should be cached
-			tc.modFile.FetchDeps(dirPath, testRemote, true)
-			for _, c := range tc.cachedStdOutContains {
-				assert.Contains(t, buf.String(), c)
+				// Try fetching again. Should be cached
+				tc.modFile.FetchDeps(dirPath, testRemote, true)
+				for _, c := range tc.cachedStdOutContains {
+					assert.Contains(t, buf.String(), c)
+				}
 			}
 		})
 	}