Change GitHub auth to be for GitHub Enterprise Server #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/mouismail/actions-controller?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
pkg/clients/github.gofile, focusing on simplifying the initialization of GitHub clients by removing redundant methods and streamlining the client initialization process.Simplification of GitHub Client Initialization:
initCloudClientsmethod, which included the initialization of cloud clients and fetching the installation ID and token. This logic has been consolidated into theinitClientsmethod. (pkg/clients/github.go)GetCloudV3ClientandGetCloudV3AppClientmethods, which were previously used to create new GitHub client instances. These methods are no longer needed due to the changes in the initialization process. (pkg/clients/github.go)These changes streamline the GitHub client initialization process, making the codebase cleaner and more maintainable.
For more details, open the Copilot Workspace session.