Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination and related hurdles #3

Open
tyler-sommer opened this issue Sep 28, 2017 · 1 comment
Open

Pagination and related hurdles #3

tyler-sommer opened this issue Sep 28, 2017 · 1 comment

Comments

@tyler-sommer
Copy link
Member

After a time, the industry jobs page becomes very long and slow. The app needs a way to paginate the data, which could prove interesting for the model API. Some of the API calls allow paging, but even if not it can be implemented at the database layer. The same will be true for the assets page.

I am considering refreshing industry jobs, assets, and blueprints on a regular basis in a background worker. The feature would be opt-in, so a settings page might be in order. That would also necessitate forming some kind of "user profile".

Pagination would also make necessary a separate endpoint for each type that returns paginated data.

Other things to consider:

  • Possible to paginate in the grpc layer?
  • Use react or the like for the browser end of things; go all-in on RESTish endpoints and lots of javascript.
    • Might even be possible to make the front-end consume grpc.
@tyler-sommer
Copy link
Member Author

3b61c38 added pagination that I think can be generalized decently. It still requires all results be loaded from the database for each page, but without re-working the model in a total sort of way, I think it's going to have to look like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant