Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix repeat options in AnimationSequence #2915

Open
thevinter opened this issue Nov 29, 2024 · 1 comment
Open

[BUG] Fix repeat options in AnimationSequence #2915

thevinter opened this issue Nov 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@thevinter
Copy link

Description:

While passing an array of animate definitions to animate() certain transition types (such as repeat) are completely ignored

CodeSandbox reproduction of the bug:

https://codesandbox.io/p/devbox/dyl4hm

Steps to reproduce

Open the codesandbox and refresh the main page

Expected behavior

Since both animate() calls operate on the same animation I would expect both squares to behave identically

@thevinter thevinter added the bug Something isn't working label Nov 29, 2024
@mattgperry mattgperry changed the title [BUG] Animation of A Sequence Ignores Certain Trainsition Types [BUG] Fix repeat options in AnimationSequence Dec 13, 2024
@mattgperry
Copy link
Collaborator

There's a fundamental technical difference here in that the normal repeat options apply to the animation as a whole.

animate(sequence, { repeat: 6, repeatType: "mirror" })

Whereas the sequence generates keyframes to then pass to an animation. Not that the user should know or care about this. But highlights, for instance, how repeat: Infinity would be impossible. And that there could be overhead adding support for these. So what I'll do is take a look into adding support (perhaps for a finite number of repeats) and see how much overhead it produces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants