From 5c090671b1b792d447414cae36330a2445462fb5 Mon Sep 17 00:00:00 2001 From: Harshit Agarwal Date: Thu, 21 Jun 2012 11:59:41 +0530 Subject: [PATCH] Harshit & Duck | Upgrading schedule-testing to quartz 2.1.5 and bumped the version of motech-schedule-testing to 0.4-SNAPSHOT, so that it does not affect teams who are using quartz 1.8.5. --- .gitignore | 1 + .../motech-delivery-batch-replication/pom.xml | 8 ++++---- motech-delivery-tools/motech-schedule-testing/pom.xml | 6 ++++-- .../delivery/schedule/util/FakeSchedule.java | 10 ++++++---- 4 files changed, 15 insertions(+), 10 deletions(-) diff --git a/.gitignore b/.gitignore index 29faa73..a39d3c6 100644 --- a/.gitignore +++ b/.gitignore @@ -21,3 +21,4 @@ test-output/ .DS_Store motech-delivery-tools/motech-document/velocity.log motech-delivery-tools/motech-document/motech_api_doc.pdf +*.log diff --git a/motech-delivery-tools/motech-delivery-batch/motech-delivery-batch-replication/pom.xml b/motech-delivery-tools/motech-delivery-batch/motech-delivery-batch-replication/pom.xml index e162435..0e91632 100644 --- a/motech-delivery-tools/motech-delivery-batch/motech-delivery-batch-replication/pom.xml +++ b/motech-delivery-tools/motech-delivery-batch/motech-delivery-batch-replication/pom.xml @@ -3,9 +3,9 @@ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> - motech-delivery - org.motechproject - 0.3-SNAPSHOT + motech-delivery-batch + org.motechproject.batch + 0.1-SNAPSHOT 4.0.0 @@ -23,4 +23,4 @@ - \ No newline at end of file + diff --git a/motech-delivery-tools/motech-schedule-testing/pom.xml b/motech-delivery-tools/motech-schedule-testing/pom.xml index d93fa88..52e9aa7 100644 --- a/motech-delivery-tools/motech-schedule-testing/pom.xml +++ b/motech-delivery-tools/motech-schedule-testing/pom.xml @@ -2,13 +2,15 @@ + 4.0.0 + motech-delivery-tools org.motechproject 0.3-SNAPSHOT - 4.0.0 + 0.4-SNAPSHOT motech-schedule-testing @@ -60,7 +62,7 @@ org.quartz-scheduler quartz - 1.8.5 + 2.1.5 diff --git a/motech-delivery-tools/motech-schedule-testing/src/main/java/org/motechproject/delivery/schedule/util/FakeSchedule.java b/motech-delivery-tools/motech-schedule-testing/src/main/java/org/motechproject/delivery/schedule/util/FakeSchedule.java index 51e5edd..9b3e180 100644 --- a/motech-delivery-tools/motech-schedule-testing/src/main/java/org/motechproject/delivery/schedule/util/FakeSchedule.java +++ b/motech-delivery-tools/motech-schedule-testing/src/main/java/org/motechproject/delivery/schedule/util/FakeSchedule.java @@ -10,6 +10,7 @@ import org.motechproject.scheduletracking.api.service.ScheduleTrackingService; import org.quartz.*; import org.quartz.impl.calendar.BaseCalendar; +import org.quartz.spi.OperableTrigger; import org.springframework.scheduling.quartz.SchedulerFactoryBean; import java.util.*; @@ -18,6 +19,7 @@ import static org.hamcrest.CoreMatchers.is; import static org.hamcrest.MatcherAssert.assertThat; import static org.motechproject.scheduletracking.api.events.constants.EventDataKeys.*; +import static org.quartz.impl.matchers.GroupMatcher.triggerGroupEquals; public class FakeSchedule { private ScheduleTrackingService trackingService; @@ -92,9 +94,9 @@ public void assertNoAlerts(String milestoneName, WindowName window) { } private void captureAlertsFor(String externalId, String scheduleName) throws SchedulerException { - for (String triggerName : scheduler.getTriggerNames("default")) { - Trigger trigger = scheduler.getTrigger(triggerName, "default"); - JobDetail detail = scheduler.getJobDetail(trigger.getJobName(), "default"); + for (TriggerKey triggerKey : scheduler.getTriggerKeys(triggerGroupEquals("default"))) { + Trigger trigger = scheduler.getTrigger(triggerKey); + JobDetail detail = scheduler.getJobDetail(JobKey.jobKey(trigger.getJobKey().getName(), "default")); JobDataMap dataMap = detail.getJobDataMap(); if (scheduleName.equals(dataMap.get(SCHEDULE_NAME)) && externalId.equals(dataMap.get(EXTERNAL_ID))) { @@ -108,7 +110,7 @@ private void captureAlertsFor(String externalId, String scheduleName) throws Sch private void storeAlertTimes(Trigger trigger, JobDetail detail, LocalDate startDate) { LocalDate endDate = startDate.plusYears(2); - List times = TriggerUtils.computeFireTimesBetween(trigger, new BaseCalendar(), startDate.toDate(), endDate.toDate()); + List times = TriggerUtils.computeFireTimesBetween((OperableTrigger) trigger, new BaseCalendar(), startDate.toDate(), endDate.toDate()); String windowName = String.valueOf(detail.getJobDataMap().get(WINDOW_NAME)); MilestoneAlert milestoneAlert = (MilestoneAlert) detail.getJobDataMap().get(MILESTONE_NAME);