-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropppping unmaintained code #148
Comments
I still use collada importer. But can probably move to opengex at some
point. I think assimp is quite good iirc, only concern would be it being a
bit lowest-common-feature set.
|
And audio example, too ;) But replacing by mesh primitives should be fine there too. And I believe the "WIP" Octree implementation uses it, but that's my responsibility to deal with. |
New item added: completely dropping the The last reason why I wanted to keep it was Windows Phone SDK that still depends on MSVC 2013, but since that platform is also almost dead, the pain-to-portability ratio is too high. Please raise objections if you have a different opinion. |
We might need some line - sphere/box collision detection for selecting objects but we could also implement it ourselves. As I have seen so far, the shapes are currently implemented for floats only anyway. |
@ManuelK89 The actual "brain" of the |
The |
GlutApplication is deprecated since d70f75a. |
|
|
Everything is removed now:
Together with #81 it totalled in around 18k lines removed. Not bad 🔥 🔥 🔥 |
Assuming nobody uses the following parts anymore, I propose deprecating and then dropping them:
Shapes
namespace. Poorly designed, sparsely implemented and of no real use. This would make Finish collision detection algorithms #5 and also theDebugTools::ShapeRenderer
class obsolete. Affects the Bullet and Audio example, which would need to be reworked without these (shouldn't be hard, we could also make use of instancing there) -- deprecated in 8efc6b3BulletIntegration::convertShape()
-- mosra/magnum-integration@968fa40@collisionoperator
or whatever is it named from Doxyfile and Coding Style docsPlatform::GlutApplication
class. Is there any platform that has GLUT but doesn't have SDL2? The class is not receiving any updates anymore and I'm not sure if it even works. -- deprecated in d70f75aColladaImporter
plugin. Depends on outdatedQt4
, supports only some features because COLLADA files are impossible to parse and I don't plan to extend it anymore. I propose replacing it with general-purpose importer based onAssimp
(Data import/export plugin improvements #146) -- deprecated in mosra/magnum-plugins@35ee1a2compatibility
branch, along with support for GCC 4.4, 4.5, 4.6 and MSVC 2013.The text was updated successfully, but these errors were encountered: