Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rigid bodies for GSD writer. #846

Open
chrisjonesBSU opened this issue Sep 14, 2024 · 0 comments · May be fixed by #850
Open

Implement rigid bodies for GSD writer. #846

chrisjonesBSU opened this issue Sep 14, 2024 · 0 comments · May be fixed by #850
Assignees
Labels
conversions conversions of GMSO to and from other format

Comments

@chrisjonesBSU
Copy link
Contributor

chrisjonesBSU commented Sep 14, 2024

After switching GMSO to the backend writer in mBuild for HOOMD snapshots and GSD files, I did some poking around about how to hand off the rigid ID when converting from mbuild to GMSO. It looks like the snapshot writers don't yet support rigid body IDs, and even if they did, it looks like we're missing a way to pass in rigid body IDs in convert_mbuild.py

convert_hoomd.py accepts a rigid_bodies argument when writing out a Hoomd snapshot, but there is no way to get this info from the topology object. Since in most workflows, the rigid body IDs are created and stored in the mBuild Compound class, I think this information should be passed along to GMSO when applicable.

We would need to 1) create a rigid_ids attribute in gmso.core.Topology which would be a list of ints, and 2) populate this attribute when parsing the Compound in from_mbuild.

@chrisjonesBSU chrisjonesBSU added the conversions conversions of GMSO to and from other format label Sep 14, 2024
@chrisjonesBSU chrisjonesBSU changed the title Add rigid_bodies attribute to Topology Implement rigid bodies for GSD writer. Sep 14, 2024
@chrisjonesBSU chrisjonesBSU self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conversions conversions of GMSO to and from other format
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant