-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Pin" Flag? #1
Comments
Unfortunately I am not sure how to implement such a feature. I also prefer my videos to be pinned and I actually manually pin them each time. The reason It's not implemented is because, as far as I can tell, there is no way to pin a specific windows but only the focused one. I might be wrong here or relying on outdated information but if you know of a way to do it I'd be more than happy to implement it. |
Yes, you are correct that you cannot specify which window to pin, only the active window. I have no specific workaround to that problem. However, when a window is newly opened, it does become the active window; and so when I edited the code to dispatch TogglePin afterwards, that worked for me. Of course, there may be unforeseen problems with this approach, so it may be worth requesting that hyprland-rs allows to specify a window for the ::TogglePin dispatch in the same way as ::ToggleFloating does |
At first I tried the same thing but after some testing it proved unreliable, I am not sure if its a bug or intended behavior but the active window can change between dispatches
Unfortunately its not a limitation of hyprland-rs but a limitation of hyprland socket itself. As far as I'm aware hyprland does not expose such functionality
While writing this issue I actually realized a potential workaround, if we force the pip window to be active right before we send the pin dispatch, it might avoid any inconsistencies |
According to this documentation, it does. Unsure if that is new functionality, which would explain why hyperland-rs does not extend that? |
I am pretty sure its new functionality or at least it wasn't there when I needed it. I'll open a pr on hyprland-rs but that might have to wait a bit since I realized that that project is not licensed properly. |
I've left an issue on that repo at hyprland-community/hyprland-rs#146 Thanks for your help figuring out the root cause |
Thanks for that. As soon as that is implemented it should be trivial to update this repo |
Starting with release 0.2.0 windows now get properly pinned. As usual you can compile it yourself or download the latest release. Thanks for making me aware this was possible. |
I prefer my PiP videos to be "pinned" between workspaces. This is a personal preference thing, and I have already edited it for my own use case locally.
Is there any interest in this being integrated upstream, potentially as a flag, ie
The text was updated successfully, but these errors were encountered: