Merge pull request #652 from morpho-org/fix/revert-already-set

fix(authorization): revert already set error

Author: MerlinEgalite

src/Morpho.sol

@@ -444,10 +444,7 @@ contract Morpho is IMorphoStaticTyping {
 
     /// @inheritdoc IMorphoBase
     function setAuthorizationWithSig(Authorization memory authorization, Signature calldata signature) external {
-        require(
-            authorization.isAuthorized != isAuthorized[authorization.authorizer][authorization.authorized],
-            ErrorsLib.ALREADY_SET
-        );
+        /// Do not check whether authorization is already set because the nonce increment is a desired side effect.
         require(block.timestamp <= authorization.deadline, ErrorsLib.SIGNATURE_EXPIRED);
         require(authorization.nonce == nonce[authorization.authorizer]++, ErrorsLib.INVALID_NONCE);
 

test/forge/integration/AuthorizationIntegrationTest.sol

@@ -26,22 +26,6 @@ contract AuthorizationIntegrationTest is BaseTest {
         morpho.setAuthorization(addressFuzz, true);
     }
 
-    function testAlreadySetWithSig(Authorization memory authorization, Signature memory sig) public {
-        authorization.isAuthorized = false;
-        authorization.authorizer = address(this);
-        authorization.deadline = block.timestamp;
-        authorization.nonce = 0;
-
-        vm.expectRevert(bytes(ErrorsLib.ALREADY_SET));
-        morpho.setAuthorizationWithSig(authorization, sig);
-
-        morpho.setAuthorization(authorization.authorized, true);
-
-        authorization.isAuthorized = true;
-        vm.expectRevert(bytes(ErrorsLib.ALREADY_SET));
-        morpho.setAuthorizationWithSig(authorization, sig);
-    }
-
     function testSetAuthorizationWithSignatureDeadlineOutdated(
         Authorization memory authorization,
         uint256 privateKey,