Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors changed drastically after the nvim 10.0 update #459

Open
Rahim-444 opened this issue May 17, 2024 · 5 comments
Open

Colors changed drastically after the nvim 10.0 update #459

Rahim-444 opened this issue May 17, 2024 · 5 comments

Comments

@Rahim-444
Copy link

nvim 9.5
image

nvim 10.0
image
@plgruener
Copy link

plgruener commented May 18, 2024 •
edited
Loading

You're reporting this issue to the wrong repo. If the change was caused by an update of nvim, you gotta report it there. (I've seen similar reports for multiple colorschemes now, but idk if that breaking change was intentional or not).
In fact this repo (the original gruvbox) has not received an update to the colors or highlight groups in over 6 years (just view the commit log). Plus it's not even neovim-aware. If you want a more up-to-date gruvbox, checkout gruvbox-community or gruvbox.nvim.

edit: this was an intentional breaking change by Neovim, see https://neovim.io/doc/user/news-0.10.html

@Rahim-444
Copy link
Author

the problem isn't related to nvim, they just changed the original colorScheme, most color schemes set their own colors for everything so if nvim changes its colors i won't affect the color scheme, this is not the case for gruvbox.
example : gruvbox
image
tokyonight
image

@ArtemChandragupta
Copy link

I have this issue too. Any progress?

natemccurdy added a commit to natemccurdy/dotfiles that referenced this issue May 21, 2024
@natemccurdy
neovim 0.10.0: Revamp colors, airline, and bufferline
de5c65a 
My gruvbox and airline colors broke with Neovim 0.10.0.

* morhetz/gruvbox#459
* https://neovim.io/doc/user/news-0.10.html

To fix it, I had to ditch the unmaintained gruvbox theme and switched to
a lua-based gruvbox theme: ellisonleao/gruvbox.nvim

To fix airline's colors, I had to switch to a lua-based airline plugin:
lualine. I don't like lualine's bufferline implementation, so I added
akinsho/bufferline.nvim to handle my bufferline.

This also switches to using nvim-treesitter for all syntax highlighting.
natemccurdy added a commit to natemccurdy/dotfiles that referenced this issue May 22, 2024
@natemccurdy
neovim 0.10.0: Revamp colors, airline, and bufferline
2eecb75 
My gruvbox and airline colors broke with Neovim 0.10.0.

* morhetz/gruvbox#459
* https://neovim.io/doc/user/news-0.10.html

To fix everything, I:

* ditched the unmaintained morhetz/gruvbox theme and switched to a
  lua-based gruvbox theme, ellisonleao/gruvbox.nvim
* switched from bling/vim-airline to a lua-based airline plugin,
  nvim-lualine/lualine.nvim.
* I don't like lualine's bufferline implementation, so I added
  akinsho/bufferline.nvim to handle my bufferline.
* updated to meslo nerd fonts v3 since v2 didn't have the right glyphs
  for lualine.
* now use nvim-treesitter for all syntax highlighting as that has better
  compatability with neovim and all the new plugins.
* updated powerlevel10k and reconfigured for nerd fronts v3.
natemccurdy added a commit to natemccurdy/dotfiles that referenced this issue May 22, 2024
@natemccurdy
neovim 0.10.0: Revamp colors, airline, and bufferline
02aa379 
My gruvbox and airline colors broke with Neovim 0.10.0.

* morhetz/gruvbox#459
* https://neovim.io/doc/user/news-0.10.html

To fix everything, I:

* ditched the unmaintained morhetz/gruvbox theme and switched to a
  lua-based gruvbox theme, ellisonleao/gruvbox.nvim
* switched from bling/vim-airline to a lua-based airline plugin,
  nvim-lualine/lualine.nvim.
* I don't like lualine's bufferline implementation, so I added
  akinsho/bufferline.nvim to handle my bufferline.
* updated to meslo nerd fonts v3 since v2 didn't have the right glyphs
  for lualine.
* now use nvim-treesitter for all syntax highlighting as that has better
  compatability with neovim and all the new plugins.
* updated powerlevel10k and reconfigured for nerd fronts v3.
natemccurdy added a commit to natemccurdy/dotfiles that referenced this issue May 22, 2024
@natemccurdy
neovim 0.10.0: Revamp colors, airline, and bufferline
aa47252 
My gruvbox and airline colors broke with Neovim 0.10.0.

* morhetz/gruvbox#459
* https://neovim.io/doc/user/news-0.10.html

To fix everything, I:

* ditched the unmaintained morhetz/gruvbox theme and switched to a
  lua-based gruvbox theme, ellisonleao/gruvbox.nvim
* switched from bling/vim-airline to a lua-based airline plugin,
  nvim-lualine/lualine.nvim.
* I don't like lualine's bufferline implementation, so I added
  akinsho/bufferline.nvim to handle my bufferline.
* updated to meslo nerd fonts v3 since v2 didn't have the right glyphs
  for lualine.
* now use nvim-treesitter for all syntax highlighting as that has better
  compatability with neovim and all the new plugins.
* updated powerlevel10k and reconfigured for nerd fronts v3.
natemccurdy added a commit to natemccurdy/dotfiles that referenced this issue May 23, 2024
@natemccurdy
neovim 0.10.0: Revamp colors, airline, and bufferline
e102cd5 
My gruvbox and airline colors broke with Neovim 0.10.0.

* morhetz/gruvbox#459
* https://neovim.io/doc/user/news-0.10.html

To fix everything, I:

* ditched the unmaintained morhetz/gruvbox theme and switched to a
  lua-based gruvbox theme, ellisonleao/gruvbox.nvim
* switched from bling/vim-airline to a lua-based airline plugin,
  nvim-lualine/lualine.nvim.
* I don't like lualine's bufferline implementation, so I added
  akinsho/bufferline.nvim to handle my bufferline.
* updated to meslo nerd fonts v3 since v2 didn't have the right glyphs
  for lualine.
* now use nvim-treesitter for all syntax highlighting and indentation as
  that has better compatability with neovim and all the new plugins.
* updated powerlevel10k and reconfigured for nerd fronts v3.

Note: the puppet grammar for treesitter doesn't have heredoc support and
doesn't align hash rockets, but running PuppetLintFix fixes those
issues.
natemccurdy added a commit to natemccurdy/dotfiles that referenced this issue May 23, 2024
@natemccurdy
neovim 0.10.0: Revamp colors, airline, and bufferline
6f2b046 
My gruvbox and airline colors broke with Neovim 0.10.0.

* morhetz/gruvbox#459
* https://neovim.io/doc/user/news-0.10.html

To fix everything, I:

* ditched the unmaintained morhetz/gruvbox theme and switched to a
  lua-based gruvbox theme, ellisonleao/gruvbox.nvim
* switched from bling/vim-airline to a lua-based airline plugin,
  nvim-lualine/lualine.nvim.
* I don't like lualine's bufferline implementation, so I added
  akinsho/bufferline.nvim to handle my bufferline.
* updated to meslo nerd fonts v3 since v2 didn't have the right glyphs
  for lualine.
* now use nvim-treesitter for all syntax highlighting and indentation as
  that has better compatability with neovim and all the new plugins.
* updated powerlevel10k and reconfigured for nerd fronts v3.

Note: the puppet grammar for treesitter doesn't have heredoc support and
doesn't align hash rockets, but running PuppetLintFix fixes those
issues.
@Nukesor
Copy link

Nukesor commented May 29, 2024 •
edited
Loading

For any neovim users, just switch to ellisonleao/gruvbox.nvim, which is a Neovim Lua port that works just fine (It's also well-maintained)

@ursi
Copy link

ursi commented Aug 8, 2024

I don't configure neovim with lua, and I found the default settings of the lua port mentioned above to be different than what I wanted. gruvbox-community worked as a drop-in replacement for me.

ursi added a commit to ursi/config that referenced this issue Aug 8, 2024
@ursi
Switch to gruvbox-community
42d4a14 
standard gruvbox colors don't work right on neovim anymore
morhetz/gruvbox#459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Nukesor @plgruener @ursi @ArtemChandragupta @Rahim-444