Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark palette image in README is corrupted on Chrome #443

Open
geoelectric opened this issue Feb 18, 2023 · 2 comments
Open

Dark palette image in README is corrupted on Chrome #443

geoelectric opened this issue Feb 18, 2023 · 2 comments

Comments

@geoelectric
Copy link

geoelectric commented Feb 18, 2023

It's some kind of Github caching issue, as the problem doesn't appear in Firefox or Safari. I did disable all extensions first, and I'm pretty sure I've noticed this from two different machines.

Here's what shows in Chrome. Note the bottom is lopped off:

Screen Shot 2023-02-17 at 5 32 25 PM

If I open the image, keeping in mind it'll be the Github cached version, it persists:

Screen Shot 2023-02-17 at 5 34 36 PM

If I open the imgur version instead, the one listed in the actual README, it's fine:

Screen Shot 2023-02-17 at 5 35 07 PM

The problem doesn't occur on Safari or Firefox. I did disable all extensions in Chrome and emptied the cache. I'm running Chrome v110.0.5481.100 (Official Build) (x86_64)

@geoelectric
Copy link
Author

On another note, I couldn't find the hex palette colors ANYWHERE in the doc text. Are these images really the only official documentation of the palettes???

If so, that's astounding for such a popular scheme that revolves entirely around a fixed and finely crafted palette everywhere. I realize the project is essentially dead/frozen, but it'd be nice if someone would at least update the docs to fix the image and add a text list of hex codes a person can copy/paste. Solarized is even deader, and they managed to at least do that.

@Zazucki
Copy link

Zazucki commented Jan 18, 2024

On another note, I couldn't find the hex palette colors ANYWHERE in the doc text. Are these images really the only official documentation of the palettes???

If so, that's astounding for such a popular scheme that revolves entirely around a fixed and finely crafted palette everywhere. I realize the project is essentially dead/frozen, but it'd be nice if someone would at least update the docs to fix the image and add a text list of hex codes a person can copy/paste. Solarized is even deader, and they managed to at least do that.

You can check

gruvbox/colors/gruvbox.vim

Lines 89 to 132 in f1ecde8

let s:gb.dark0_hard = ['#1d2021', 234] " 29-32-33
let s:gb.dark0 = ['#282828', 235] " 40-40-40
let s:gb.dark0_soft = ['#32302f', 236] " 50-48-47
let s:gb.dark1 = ['#3c3836', 237] " 60-56-54
let s:gb.dark2 = ['#504945', 239] " 80-73-69
let s:gb.dark3 = ['#665c54', 241] " 102-92-84
let s:gb.dark4 = ['#7c6f64', 243] " 124-111-100
let s:gb.dark4_256 = ['#7c6f64', 243] " 124-111-100
let s:gb.gray_245 = ['#928374', 245] " 146-131-116
let s:gb.gray_244 = ['#928374', 244] " 146-131-116
let s:gb.light0_hard = ['#f9f5d7', 230] " 249-245-215
let s:gb.light0 = ['#fbf1c7', 229] " 253-244-193
let s:gb.light0_soft = ['#f2e5bc', 228] " 242-229-188
let s:gb.light1 = ['#ebdbb2', 223] " 235-219-178
let s:gb.light2 = ['#d5c4a1', 250] " 213-196-161
let s:gb.light3 = ['#bdae93', 248] " 189-174-147
let s:gb.light4 = ['#a89984', 246] " 168-153-132
let s:gb.light4_256 = ['#a89984', 246] " 168-153-132
let s:gb.bright_red = ['#fb4934', 167] " 251-73-52
let s:gb.bright_green = ['#b8bb26', 142] " 184-187-38
let s:gb.bright_yellow = ['#fabd2f', 214] " 250-189-47
let s:gb.bright_blue = ['#83a598', 109] " 131-165-152
let s:gb.bright_purple = ['#d3869b', 175] " 211-134-155
let s:gb.bright_aqua = ['#8ec07c', 108] " 142-192-124
let s:gb.bright_orange = ['#fe8019', 208] " 254-128-25
let s:gb.neutral_red = ['#cc241d', 124] " 204-36-29
let s:gb.neutral_green = ['#98971a', 106] " 152-151-26
let s:gb.neutral_yellow = ['#d79921', 172] " 215-153-33
let s:gb.neutral_blue = ['#458588', 66] " 69-133-136
let s:gb.neutral_purple = ['#b16286', 132] " 177-98-134
let s:gb.neutral_aqua = ['#689d6a', 72] " 104-157-106
let s:gb.neutral_orange = ['#d65d0e', 166] " 214-93-14
let s:gb.faded_red = ['#9d0006', 88] " 157-0-6
let s:gb.faded_green = ['#79740e', 100] " 121-116-14
let s:gb.faded_yellow = ['#b57614', 136] " 181-118-20
let s:gb.faded_blue = ['#076678', 24] " 7-102-120
let s:gb.faded_purple = ['#8f3f71', 96] " 143-63-113
let s:gb.faded_aqua = ['#427b58', 66] " 66-123-88
let s:gb.faded_orange = ['#af3a03', 130] " 175-58-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants