✨ support repo in requires syntax. resolves #97

Author: chfw

Diff for: .moban.cd/changelog.yml

@@ -1,6 +1,12 @@
 name: moban
 organisation: moremoban
 releases:
+- changes:
+  - action: Added
+    details:
+    - "`#97`: requires will clone a repo if given. Note: only github, gitlab, bitbucket for now"
+  date: unreleased
+  version: 0.3.1
 - changes:
   - action: Added
     details:

Diff for: .moban.d/setup.py

@@ -2,3 +2,5 @@
 
 {%block platform_block%}
 {%endblock%}
+
+{%block morefiles%} 'CONTRIBUTORS.rst',{%endblock%}

Diff for: CHANGELOG.rst

@@ -1,6 +1,15 @@
 Change log
 ================================================================================
 
+0.3.1 - unreleased
+--------------------------------------------------------------------------------
+
+Added
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+#. `#97 <https://github.com/moremoban/moban/issues/97>`_: requires will clone a
+   repo if given. Note: only github, gitlab, bitbucket for now
+
 0.3.0 - 27-18-2018
 --------------------------------------------------------------------------------
 

Diff for: moban/mobanfile.py

@@ -8,7 +8,7 @@
 import moban.constants as constants
 import moban.reporter as reporter
 from moban.engine import ENGINES
-from moban.utils import merge, parse_targets
+from moban.utils import merge, parse_targets, git_clone
 from moban.utils import expand_directories, pip_install
 from moban.copier import Copier
 
@@ -137,4 +137,25 @@ def extract_target(options):
 
 
 def handle_requires(requires):
-    pip_install(requires)
+    pypi_pkgs = []
+    git_repos = []
+    for require in requires:
+        if is_repo(require):
+            git_repos.append(require)
+        else:
+            pypi_pkgs.append(require)
+    if pypi_pkgs:
+        pip_install(pypi_pkgs)
+    if git_repos:
+        git_clone(git_repos)
+
+
+def is_repo(require):
+    return (
+        require.startswith('http') and
+        (
+            'github.com' in require or
+            'gitlab.com' in require or
+            'bitbucket.com' in require
+        )
+    )

Diff for: moban/utils.py

@@ -147,6 +147,15 @@ def pip_install(packages):
     )
 
 
+def git_clone(repos):
+    import subprocess
+
+    for repo in repos:
+        subprocess.check_call(
+            ['git', 'clone', repo]
+        )
+
+
 def get_template_path(template_dirs, template):
     temp_dir = ""
     for a_dir in template_dirs:

Diff for: tests/test_moban_file.py

@@ -35,9 +35,37 @@ def test_no_moban_file(self):
 
 
 @patch("moban.mobanfile.pip_install")
-def test_handle_requires(fake_pip_install):
+def test_handle_requires_pypkg(fake_pip_install):
     modules = ["package1", "package2"]
     from moban.mobanfile import handle_requires
 
     handle_requires(modules)
     fake_pip_install.assert_called_with(modules)
+
+
+@patch("moban.mobanfile.git_clone")
+def test_handle_requires_repos(fake_git_clone):
+    repos = ["https://github.com/my/repo", "https://gitlab.com/my/repo"]
+    from moban.mobanfile import handle_requires
+
+    handle_requires(repos)
+    fake_git_clone.assert_called_with(repos)
+
+
+def test_is_repo():
+    repos = [
+        "https://github.com/my/repo",
+        "https://gitlab.com/my/repo",
+        "https://bitbucket.com/my/repo",
+        "https://unsupported.com/my/repo",
+        "invalid/repo/rul"
+    ]
+    from moban.mobanfile import is_repo
+
+    actual = [
+        is_repo(repo) for repo in repos
+    ]
+    expected = [
+        True, True, True, False, False
+    ]
+    eq_(expected, actual)

Diff for: tests/test_utils.py

@@ -102,3 +102,13 @@ def test_pip_install(fake_check_all):
     fake_check_all.assert_called_with(
         [sys.executable, "-m", "pip", "install", "package1 package2"]
     )
+
+
+@patch("subprocess.check_call")
+def test_git_clone(fake_check_all):
+    from moban.utils import git_clone
+
+    git_clone(["https://github.com/my/repo", "https://gitlab.com/my/repo"])
+    fake_check_all.assert_called_with(
+        ["git", "clone", "https://gitlab.com/my/repo"]
+    )