Add CopyTo operator
#964
Closed
Add CopyTo operator
#964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 92.52% 92.51% -0.02%
==========================================
Files 113 114 +1
Lines 3440 3498 +58
Branches 1024 1040 +16
==========================================
+ Hits 3183 3236 +53
- Misses 192 197 +5
Partials 65 65
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| { | ||
| return CopyTo(source, array, index); | ||
| } | ||
| else |
There was a problem hiding this comment.
💡You don't need the else statement here, because there is no more instruction after it.
| var i = index; | ||
| foreach (var el in source) | ||
| { | ||
| if (i < list.Count) |
There was a problem hiding this comment.
💡 Sometimes you use { } and sometimes you don't use it in if statement. Adopt a single code style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
CopyTooperator, which operates similar toArray.CopyToorList.CopyTo. This is useful for copying data from a stream to a pre-existing array orIList<>, such as an array rented from anArrayPool<>.To match semantics with existing methods, this method will throw an exception if there is not enough room in the specified destination for the input data to be stored. If the consumer does not care about excess data, they can apply the
Takeoperator before callingCopyToto avoid the exception.One difference between this operator and the collection methods is that this version returns an
int. With the collection methods, it is easy to know pre or post how much data should be copied, because theCount/Lengthproperty is available. ForIEnumerable<>this information is not as readily available, soCopyToreturns how many elements were stored in the destination.Fixes #963