Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login is only attempted when mopidy starts #259

Closed
Gigahawk opened this issue Mar 30, 2020 · 9 comments
Closed

Login is only attempted when mopidy starts #259

Gigahawk opened this issue Mar 30, 2020 · 9 comments

Comments

@Gigahawk
Copy link

If mopidy is started without an internet connection, the Spotify login will fail, and no attempt to reconnect is made even if the connection is restored.

The plugin should periodically attempt to login if it is currently not logged in.

@kingosticks
Copy link
Member

Alternatively, could you ensure you wait for your Internet connection to become ready before starting Mopidy? The Mopidy systemd unit waits for the network target.

@Gigahawk
Copy link
Author

Gigahawk commented Mar 30, 2020

I'm on a distro that doesn't use systemd, I just have mopidy start with my window manager.

It's also not really reasonable to have mopidy unavailable until my laptop connects to the internet.

@s-martin
Copy link

We use mopidy-spotify in our project and users have reported just recently that login to Spotify doesn't work anymore. Reason could be, that internet connection is not available yet, but this was never an issue in the past.
See:
MiczFlor/RPi-Jukebox-RFID#893
MiczFlor/RPi-Jukebox-RFID#901

Were there any changes in 3.0.2?

@kingosticks
Copy link
Member

The changelog is available online but there were no changes in Mopidy 3.0.2 that would impact the ability of libspotify to login.

@s-martin
Copy link

The changelog is available online but there were no changes in Mopidy 3.0.2 that would impact the ability of libspotify to login.

Thanks for the info and pointing us into the right direction.

@kobbejager
Copy link

I have the same issue on Rasbian Buster Lite. In /etc/init.d/mopidy network is listed as a requirement, but apparently it does not wait for the (wired) network to be fully started. Anyway, I agree with the initial comment that Mopidy-Spotify should try to reconnect regularly.

@jaor
Copy link

jaor commented May 22, 2020 via email

@kingosticks
Copy link
Member

Mopidy requires the network and we already specify that in our service files. If your system isn't waiting for the network to be ready, I'm finding it hard to see how that's a Mopidy issue. I've already mentioned the fix for Raspbian above.

I get there may be some other case that I don't appreciate and so if someone wants to submit a PR for this (that works properly and is tested) then I will review it.

@kingosticks
Copy link
Member

Given the way streaming with gst-spotify-plugin is decoupled from the Web API login, this has become easier to do. If someone wants to sort it out, they are welcome to re-open this issue and do that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants