Restore hash #174
Merged
Restore hash #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var projects = Object.keys(pkgProjects).forEach(function(project){ | ||
| pathObject[project] = pkgProjects[project].hashStorage; | ||
| }) | ||
| return pathObject; |
There was a problem hiding this comment.
You can do nicer with reduce instead.
return Object.keys(pkgProjects).reduce(function(pathObject, project){
pathObject[project] = pkgProjects[project].hashStorage;
}, {});And don't forget the ;.
There was a problem hiding this comment.
And when you use the reduce version, you don't need the extra iife/function/closure.
|
I commented on a few things, but really great work so far! |
|
@arian nice feedback! will fix during the day. |
| @@ -47,4 +63,11 @@ module.exports = function(app){ | |||
| app.get('/more/guides', more, guides.index); | |||
| app.get('/more/guides/:guide', more, guides.article); | |||
|
|
|||
| // hash build redirect | |||
| var regex = /more\/([a-z]+[0-9]+[a-z0-9]*|[0-9]+[a-z]+[a-z0-9]*)$/; | |||
There was a problem hiding this comment.
Same as for core, we can probably just redirect /more/:hash, rather than a regex.
There was a problem hiding this comment.
Also makes it possible to have "custom" hashes, in case we'd want to do that for some reason. Old website functionality did have that as well, I don't know if any exist.
|
Updated, review welcome :) |
|
Awesome, reviewing... |
- now it adds the hash link to the download file, as it used to be - improved error handling in the builderHash - use a separate config file for the locations, so you can specify that in dev and production.
Fix when there are no results for loadHash
|
I made some improvements: SergioCrisostomo#1 |
Restore hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore hash functionality in builder. (fixes #169)
Restore visual behaviour when selecting modules. (fixes #171)
Ok, this went a big pull request.
Basically it:
core/5jhj546oh54uhyfld98tocore/builder/5jhj546oh54uhyfld98- same for More.tests/database/which are usable for testing this and eventually future specs. (Maybe a fallback to those files should be added for when running the site locally/in development)Thank you @timwienk for help on this