From eb527cb50709bead9d970b879ef428eb7cfb5106 Mon Sep 17 00:00:00 2001 From: ClotildeToullec Date: Tue, 3 Sep 2024 09:12:23 +0200 Subject: [PATCH] Fix Propagate behaviour in DSM --- ...DependencyStructuralMatrixBrowser.class.st | 4 ++-- ...dencyStructuralMatrixBrowserModel.class.st | 14 +++++++------ ...ndencyStructuralMatrixBrowserTest.class.st | 20 ++++++------------- 3 files changed, 16 insertions(+), 22 deletions(-) diff --git a/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowser.class.st b/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowser.class.st index a08538028..44b627bf3 100644 --- a/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowser.class.st +++ b/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowser.class.st @@ -98,7 +98,7 @@ MiDependencyStructuralMatrixBrowser >> buildDSM [ { #category : #testing } MiDependencyStructuralMatrixBrowser >> canFollowEntity: anObject [ - ^specModel canFollowEntity: anObject + ^ specModel canFollowEntity: anObject ] { #category : #testing } @@ -129,7 +129,7 @@ MiDependencyStructuralMatrixBrowser >> initializePresenters [ { #category : #accessing } MiDependencyStructuralMatrixBrowser >> miSelectedItem [ - ^specModel selectedEntities + ^ specModel miSelectedItem ] { #category : #api } diff --git a/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowserModel.class.st b/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowserModel.class.st index 4eff71140..a56094099 100644 --- a/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowserModel.class.st +++ b/src/MooseIDE-Dependency/MiDependencyStructuralMatrixBrowserModel.class.st @@ -93,7 +93,8 @@ MiDependencyStructuralMatrixBrowserModel >> displayValueForTuple: tuple [ { #category : #accessing } MiDependencyStructuralMatrixBrowserModel >> entities [ - ^graph nodes collect: #model + + ^ graph nodes collect: #model ] { #category : #actions } @@ -146,6 +147,12 @@ MiDependencyStructuralMatrixBrowserModel >> isDiagonal: tuple [ ] +{ #category : #accessing } +MiDependencyStructuralMatrixBrowserModel >> miSelectedItem [ + + ^ self entities +] + { #category : #buildGraph } MiDependencyStructuralMatrixBrowserModel >> newGraph [ graph := AITarjan new. @@ -211,11 +218,6 @@ MiDependencyStructuralMatrixBrowserModel >> sccTuplesForTuple: tuple [ ] ] -{ #category : #accessing } -MiDependencyStructuralMatrixBrowserModel >> selectedEntities [ - ^#() -] - { #category : #settings } MiDependencyStructuralMatrixBrowserModel >> showSCCColor [ diff --git a/src/MooseIDE-Tests/MiDependencyStructuralMatrixBrowserTest.class.st b/src/MooseIDE-Tests/MiDependencyStructuralMatrixBrowserTest.class.st index c99ab5a25..7dfe22ec1 100644 --- a/src/MooseIDE-Tests/MiDependencyStructuralMatrixBrowserTest.class.st +++ b/src/MooseIDE-Tests/MiDependencyStructuralMatrixBrowserTest.class.st @@ -12,10 +12,10 @@ MiDependencyStructuralMatrixBrowserTest >> browserClass [ { #category : #running } MiDependencyStructuralMatrixBrowserTest >> initializeEntityToSelect [ - ^ { - (self method: 'method1'). - (self method: 'method2'). - (self method: 'method3') } + entityToSelect := { + (self method: 'method1'). + (self method: 'method2'). + (self method: 'method3') } ] { #category : #running } @@ -24,16 +24,8 @@ MiDependencyStructuralMatrixBrowserTest >> method: aName [ ^ FamixRepTestMethod named: aName ] -{ #category : #tests } -MiDependencyStructuralMatrixBrowserTest >> testActivateActionButtons [ - - browser actionButtons do: [ :button | self deny: button isEnabled ]. - - - -] - { #category : #'tests - tags' } MiDependencyStructuralMatrixBrowserTest >> testCanTagEntities [ - self deny: browser canTagEntities + + self deny: browser canTagEntities ]