Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateOnPreview does not display any feedback when the network is lost #1267

Open
iPabro opened this issue Sep 12, 2024 · 0 comments
Open

updateOnPreview does not display any feedback when the network is lost #1267

iPabro opened this issue Sep 12, 2024 · 0 comments
Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed

Comments

@iPabro
Copy link

iPabro commented Sep 12, 2024

MoonShine Version

2.22.1

Laravel Version

v10.48.20

PHP Version

8.2.10

Database Driver & Version

No response

Description

I encountered an issue with the updateOnPreview functionality. When there is a network loss and a field is updated, no message or feedback is shown in the preview pop-up. As a result, the changes are not saved, and the user is unaware of this issue.

Steps To Reproduce

Here is the code I'm using:

Text::make('domain')
    ->updateOnPreview(events: [
        AlpineJs::event(JsEvent::TOAST, params: ['text' => 'Success', 'type' => 'success'])
    ]);

To reproduce this issue:

In Chrome, open the Developer Tools panel.
Disable the network connection.
Try to change the value of the field.

Expected Behavior:

A notification or message should appear indicating that the changes could not be saved due to network issues.

@lee-to lee-to added help wanted Extra attention is needed good first issue Good for newcomers frontend labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants