4.6 - PHPUnit failures with Shared Question Banks

[aspark21]

Testing Moodle 4.6 for https://tracker.moodle.org/browse/MDLQA-19535

Numerous failures relating to those changes

filter_embedquestion.attempt_test/test_start_new_attempt_at_question_will_select_an_unused_questionfilter_embedquestion\attempt_test::test_start_new_attempt_at_question_will_select_an_unused_question core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/attempt_test.php:44 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.attempt_test/test_start_new_attempt_at_question_will_select_an_unused_variantfilter_embedquestion\attempt_test::test_start_new_attempt_at_question_will_select_an_unused_variant core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/attempt_test.php:92 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.attempt_test/test_start_new_attempt_at_question_reports_errorsfilter_embedquestion\attempt_test::test_start_new_attempt_at_question_reports_errors core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/attempt_test.php:132 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.attempt_test/test_discard_broken_attempt_no_usagefilter_embedquestion\attempt_test::test_discard_broken_attempt_no_usage core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/attempt_test.php:172 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.attempt_test/test_discard_broken_attempt_one_qafilter_embedquestion\attempt_test::test_discard_broken_attempt_one_qa core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/attempt_test.php:194 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.attempt_test/test_discard_broken_attempt_two_qasfilter_embedquestion\attempt_test::test_discard_broken_attempt_two_qas core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/attempt_test.php:227 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.attempt_test/test_question_renderingfilter_embedquestion\attempt_test::test_question_rendering core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/attempt_test.php:260 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.external_test/test_get_sharable_question_choices_workingfilter_embedquestion\external_test::test_get_sharable_question_choices_working core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Unknown question category.  /var/www/html/filter/embedquestion/classes/external.php:94 /var/www/html/filter/embedquestion/tests/external_test.php:65 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.external_test/test_get_sharable_question_choices_only_userfilter_embedquestion\external_test::test_get_sharable_question_choices_only_user core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Unknown question category.  /var/www/html/filter/embedquestion/classes/external.php:94 /var/www/html/filter/embedquestion/tests/external_test.php:109 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.external_test/test_get_embed_code_working_with_random_questionsfilter_embedquestion\external_test::test_get_embed_code_working_with_random_questions Attempt to read property "id" on null  /var/www/html/filter/embedquestion/classes/external.php:224 /var/www/html/filter/embedquestion/tests/external_test.php:214 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.external_test/test_get_embed_code_working with data set #0filter_embedquestion\external_test::test_get_embed_code_working with data set #0 ('abc123', 'toad', 'abc123/toad') Attempt to read property "id" on null  /var/www/html/filter/embedquestion/classes/external.php:224 /var/www/html/filter/embedquestion/tests/external_test.php:163 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.external_test/test_get_embed_code_working with data set #1filter_embedquestion\external_test::test_get_embed_code_working with data set #1 ('A/V questions', '\|---> 100%', 'A%2FV questions/%7C---> 100%25') Attempt to read property "id" on null  /var/www/html/filter/embedquestion/classes/external.php:224 /var/www/html/filter/embedquestion/tests/external_test.php:163 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.utils_test/test_get_category_by_idnumberfilter_embedquestion\utils_test::test_get_category_by_idnumber Attempt to read property "id" on null  /var/www/html/filter/embedquestion/tests/utils_test.php:48 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.utils_test/test_get_categories_with_sharable_question_choicesfilter_embedquestion\utils_test::test_get_categories_with_sharable_question_choices Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@  Array (      '' => 'Choose...' -    'pqr789' => 'Second category [pqr789] (1)'  )  /var/www/html/filter/embedquestion/tests/utils_test.php:104 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.utils_test/test_get_categories_with_sharable_question_choices_only_userfilter_embedquestion\utils_test::test_get_categories_with_sharable_question_choices_only_user Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@  Array (      '' => 'Choose...' -    'abc123' => 'Category with idnumber [abc123] (1)'  )  /var/www/html/filter/embedquestion/tests/utils_test.php:130 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.utils_test/test_get_categories_with_sharable_question_choices_should_not_include_randomfilter_embedquestion\utils_test::test_get_categories_with_sharable_question_choices_should_not_include_random Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@  Array (      '' => 'Choose...' -    'pqr789' => 'Second category with [pqr789] (1)'  )  /var/www/html/filter/embedquestion/tests/utils_test.php:243 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.utils_test/test_get_categories_with_sharable_question_choices_should_not_include_hiddenfilter_embedquestion\utils_test::test_get_categories_with_sharable_question_choices_should_not_include_hidden Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@  Array (      '' => 'Choose...' -    'pqr789' => 'Second category with [pqr789] (1)'  )  /var/www/html/filter/embedquestion/tests/utils_test.php:312 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.utils_test/test_create_attempt_at_embedded_questionfilter_embedquestion\utils_test::test_create_attempt_at_embedded_question core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Categorycontextid must refer to a course context.  /var/www/html/filter/embedquestion/tests/generator/lib.php:112 /var/www/html/filter/embedquestion/tests/generator/lib.php:138 /var/www/html/filter/embedquestion/tests/utils_test.php:346 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

filter_embedquestion.utils_test/test_get_question_bank_urlfilter_embedquestion\utils_test::test_get_question_bank_url core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: Unexpected. Only questions from the course question bank should be embedded.  /var/www/html/filter/embedquestion/classes/utils.php:459 /var/www/html/filter/embedquestion/tests/utils_test.php:387 /var/www/html/lib/phpunit/classes/advanced_testcase.php:76

[timhunt]

Of course.
Embedded questions will need major chagnes to cope with new question bank. Don't hold your breath. (OU will deploy to Moodle 5.0 in December 2025.) We will try to fix embedded questions sooner - if we have the capacity.