Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all uses of BUILD_NUMBER to BUILD_ID #303

Open
stronk7 opened this issue Jun 7, 2024 · 0 comments
Open

Move all uses of BUILD_NUMBER to BUILD_ID #303

stronk7 opened this issue Jun 7, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@stronk7
Copy link
Member

stronk7 commented Jun 7, 2024

Since long ago, the "official" name of the build number env variable in Jenkins is BUILD_ID.

While the previous BUILD_NUMBER one still works perfectly, right now we have a mix of uses. This is about to move all to be BUILD_ID (that is the official one and the one used by our newer tools).

Ref.: https://www.jenkins.io/doc/book/pipeline/jenkinsfile/#using-environment-variables

Ciao :-)

@stronk7 stronk7 added the good first issue Good for newcomers label Jun 7, 2024
stronk7 added a commit to moodlehq/moodle-ci-runner that referenced this issue Jun 7, 2024
Some old scripts still use BUILD_NUMBER instead of the
newer BUILD_ID. The later is the preferred one in new
scripts (no matter both still work).

Once moodlehq/moodle-local_ci#303 is fixed
we'll revert this change, when we have everything working with BUILD_ID.
stronk7 added a commit to moodlehq/moodle-ci-runner that referenced this issue Jun 7, 2024
Some old scripts still use BUILD_NUMBER instead of the
newer BUILD_ID. The later is the preferred one in new
scripts (no matter both still work).

Once moodlehq/moodle-local_ci#303 is fixed
we'll revert this change, when we have everything working with BUILD_ID.
stronk7 added a commit to moodlehq/moodle-ci-runner that referenced this issue Jun 7, 2024
Some old scripts still use BUILD_NUMBER instead of the
newer BUILD_ID. The later is the preferred one in new
scripts (no matter both still work).

Once moodlehq/moodle-local_ci#303 is fixed
we'll revert this change, when we have everything working with BUILD_ID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant