Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the TodoComment Sniff to require a complete regex (start, end delimiters) #141

Open
stronk7 opened this issue Mar 29, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@stronk7
Copy link
Member

stronk7 commented Mar 29, 2024

While working on a new release of the moodle-plugin-ci including the latest version of moodle-cs, it has been detected that there is a small discordance between the TodoComment sniff (and its commentRequiredRegex property/config) and the FileExpectedTags (and its preferredLicenseRegexproperty/config):

  • The TodoComment ones don't require the usual regex delimiters and adds ~ automatically.
  • The FileExpectedTags ones do require a complete regex with delimiters.

I think that the later is better, so this issue is about to change the former to also require a complete regex with delimiters.

@stronk7 stronk7 added bug Something isn't working good first issue Good for newcomers labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant