Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Respect branded and legacy activity icons when changing the activity icon purpose color #689

Open
abias opened this issue Jul 13, 2024 · 0 comments
Labels
improvement Improvement of any existing (UX, design, code, performance,...) but not a new feature and not a bug.

Comments

@abias
Copy link
Member

abias commented Jul 13, 2024

Not all activity plugins have monologo icons which can be nicely tinted with Boost Union's "Activity icon purposes" feature.

There may be activities like BigBlueButton which ship with a multicolored brand icon (as the brand appearance should be preserved) or which still ship with a legacy activity icon only.

In both cases, changing the activity purpose in Boost Union leaves just a white / weird icon.

On Moodle 4.3:
grafik

On Moodle 4.4:
grafik

On the other hand, in Moodle 4.2 / 4.3 activities icons can have a nofilter class and in Moodle 4.4 they can have a isbranded class which indicate that the icon should be left as it is.

Most of the time fixing the icon appearance with custom CSS is straightforward.
However, we should investigate more real life edge cases and then, if possible, enhance Boost Union in a way that these white / weird icon effects are mitigated.

@abias abias added the improvement Improvement of any existing (UX, design, code, performance,...) but not a new feature and not a bug. label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of any existing (UX, design, code, performance,...) but not a new feature and not a bug.
Projects
Status: No status
Development

No branches or pull requests

1 participant