Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module parameters for benchmarking and tests #224

Open
MostAwesomeDude opened this issue Feb 27, 2021 · 0 comments
Open

Use module parameters for benchmarking and tests #224

MostAwesomeDude opened this issue Feb 27, 2021 · 0 comments

Comments

@MostAwesomeDude
Copy link
Contributor

Right now we use module imports to pass two magic names, bench and unittest, to modules which ask for it. The import is completely safe, using Any guards, and was an explicit allowance in our original module-design discussions. However, the module loaders have to treat these names specially.

We could instead use module parameters. This would make it easier to compile modules so that the loader can choose at runtime whether to run benchmarks or self-tests by choosing how to parameterize the entire compiled collection of modules (the muffin) rather than having to thread names through the imports.

MostAwesomeDude added a commit that referenced this issue Mar 21, 2021
Refs #224. We don't need special parameters just for benchmarking.

Hmmmm.... But that looks like the API of...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant