Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS3 and CSSOM #4

Closed
kriskowal opened this issue Dec 9, 2012 · 18 comments
Closed

CSS3 and CSSOM #4

kriskowal opened this issue Dec 9, 2012 · 18 comments
Assignees

Comments

@kriskowal
Copy link
Member

CSSOM does not round-trip syntax it does not recognize, like gradients.

@ghost ghost assigned heatherdouglass and Stuk Dec 9, 2012
@Stuk
Copy link
Contributor

Stuk commented Dec 10, 2012

As in, it strips them out?

@kriskowal
Copy link
Member Author

Yes. The parser does not recognize them so it does not produce a node in the syntax tree. The information is lost before rewriting.

@kriskowal
Copy link
Member Author

This appears to be related to NV/CSSOM#16, which is open at time of this writing.

@ralyodio
Copy link

I'm also having problem with css gradients being stripped out because of vendor prefixes/multiple definitions issue.

@Stuk
Copy link
Contributor

Stuk commented Feb 14, 2013

The latest version of Mop has disabled CSS compression because of this issue. Are you using the latest version?

@ralyodio
Copy link

I would assume so. I just installed juice yesterday.

@Stuk
Copy link
Contributor

Stuk commented Feb 14, 2013

And Mop is still stripping out your CSS gradients?

@ralyodio
Copy link

Yes, if I define two background properties, only the last one shows up.

@Stuk
Copy link
Contributor

Stuk commented Feb 14, 2013

My mistake, I was looking at some local changes. I've pushed v0.12.4 to npm which doesn't compress CSS by default. Would you mind trying again to see if this fixes your problem? Many apologies!

@ralyodio
Copy link

I just installed juice, which should have eventually pulled in your package and it still is ignoring multiple background properties. Only the last one shows up.

@Stuk
Copy link
Contributor

Stuk commented Feb 15, 2013

What do you mean by "juice"?

@ralyodio
Copy link

npm install juice

its the package that depends on your package at least directly or indirectly. I'm using it to convert css to inline css.
https://github.com/LearnBoost/juice

@Stuk
Copy link
Contributor

Stuk commented Feb 15, 2013

Both Mop and Juice depend on CSSOM, which is where the bug is. Mop (this project) is a different tool. You'll need to comment on this bug: NV/CSSOM#16 to make your problems known.

@kriskowal
Copy link
Member Author

└─┬ [email protected]
  ├── [email protected]
  ├─┬ [email protected]
  │ └── [email protected]
  ├── [email protected]
  ├─┬ [email protected]
  │ ├─┬ [email protected]
  │ │ └── [email protected]
  │ ├── [email protected]
  │ ├── [email protected]
  │ ├── [email protected]
  │ └─┬ [email protected]
  │   ├─┬ [email protected]
  │   │ ├── [email protected]
  │   │ └─┬ [email protected]
  │   │   └── [email protected]
  │   └── [email protected]
  ├── [email protected]
  └─┬ [email protected]
    ├── [email protected]
    ├── [email protected]
    ├── [email protected]
    ├── [email protected]
    ├── [email protected]
    └── [email protected]

@ralyodio
Copy link

Oh, I thought this fixed the compressing bug for CSSOM.
How is your code working around it?

On Fri, Feb 15, 2013 at 11:50 AM, Kris Kowal [email protected]:

└─┬ [email protected]
├── [email protected]
├─┬ [email protected]
│ └── [email protected]
├── [email protected]
├─┬ [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ └─┬ [email protected]
│ ├─┬ [email protected]
│ │ ├── [email protected]
│ │ └─┬ [email protected]
│ │ └── [email protected]
│ └── [email protected]
├── [email protected]
└─┬ [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-13624654.

Anthony Ettinger
http://anthony.ettinger.name
[email protected]
+1 (831) 406-1123

@kriskowal
Copy link
Member Author

We have turned off CSS optimizations in Mop until such a time as CSSOM
fixes the problem or an alternate CSS object model that can round-trip
arbitrary CSS is created to replace it.

@Stuk
Copy link
Contributor

Stuk commented Feb 15, 2013

We're just not compressing CSS for the moment :)

@Stuk
Copy link
Contributor

Stuk commented Mar 9, 2013

This can be closed with gh-19

@Stuk Stuk closed this as completed Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants