Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] add ability to specify Authorization header from config for pushgateway #11

Open
fdobrovolny opened this issue Oct 29, 2022 · 1 comment

Comments

@fdobrovolny
Copy link
Contributor

fdobrovolny commented Oct 29, 2022

Historically push gateway recommended having a reverse proxy in front of it for handling authentication (prometheus/pushgateway#281) now it can by itself provide TLS or Basic auth.

I would like to extend this library to have a configurable Authorization header for pushes.

The config option would probably be called prometheus.pushgateway_auth by default, it would be an empty string.

I'm willing to do the work and do PR just wanted to check in first.

@pimvanpelt
Copy link
Collaborator

pimvanpelt commented Oct 30, 2022 via email

fdobrovolny added a commit to fdobrovolny/prometheus-metrics that referenced this issue Oct 30, 2022
fdobrovolny added a commit to fdobrovolny/prometheus-metrics that referenced this issue Oct 30, 2022
fdobrovolny added a commit to fdobrovolny/prometheus-metrics that referenced this issue Nov 8, 2022
fdobrovolny added a commit to fdobrovolny/prometheus-metrics that referenced this issue Nov 8, 2022
fdobrovolny added a commit to fdobrovolny/prometheus-metrics that referenced this issue Nov 8, 2022
pimvanpelt added a commit that referenced this issue Nov 9, 2022
Adds Authorization header for pushgateway #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants