-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] add ability to specify Authorization header from config for pushgateway #11
Comments
Please go right ahead. And thank you for the offer!
On Sat, 29 Oct 2022 at 23:34, Filip Dobrovolný ***@***.***> wrote:
Historically push gateway recommended having a reverse proxy in front of
it for handling authentication (prometheus/pushgateway#281
<prometheus/pushgateway#281>) now it can by
itself provide TLS or Basic auth.
I would like to extend this library to have a configurable Authentication
header for pushes.
The config option would probably be called
prometheus.pushgateway_authentication by default, it would be an empty
string.
I'm willing to do the work and do PR just wanted to check in first.
—
Reply to this email directly, view it on GitHub
<#11>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACDRSPMR6DK42AGCXRRNJVLWFWJ7PANCNFSM6AAAAAARR65LIM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Pim van Pelt ***@***.***>
PBVP1-RIPE - http://www.ipng.nl/
|
fdobrovolny
added a commit
to fdobrovolny/prometheus-metrics
that referenced
this issue
Oct 30, 2022
fdobrovolny
added a commit
to fdobrovolny/prometheus-metrics
that referenced
this issue
Oct 30, 2022
fdobrovolny
added a commit
to fdobrovolny/prometheus-metrics
that referenced
this issue
Nov 8, 2022
fdobrovolny
added a commit
to fdobrovolny/prometheus-metrics
that referenced
this issue
Nov 8, 2022
fdobrovolny
added a commit
to fdobrovolny/prometheus-metrics
that referenced
this issue
Nov 8, 2022
pimvanpelt
added a commit
that referenced
this issue
Nov 9, 2022
Adds Authorization header for pushgateway #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Historically push gateway recommended having a reverse proxy in front of it for handling authentication (prometheus/pushgateway#281) now it can by itself provide TLS or Basic auth.
I would like to extend this library to have a configurable
Authorization
header for pushes.The config option would probably be called
prometheus.pushgateway_auth
by default, it would be an empty string.I'm willing to do the work and do PR just wanted to check in first.
The text was updated successfully, but these errors were encountered: