From eb7161fb401156a27643dcf1174839bbe9edaccc Mon Sep 17 00:00:00 2001
From: Darshana Venkatesh <darshana.venkatesh@mongodb.com>
Date: Wed, 18 Dec 2024 08:53:49 -0800
Subject: [PATCH 1/2] removed validation only on change for non-persisted docs

---
 lib/mongoid/validatable/associated.rb |  2 +-
 spec/mongoid/association_spec.rb      | 60 +++++++++++++++++++++++++++
 2 files changed, 61 insertions(+), 1 deletion(-)

diff --git a/lib/mongoid/validatable/associated.rb b/lib/mongoid/validatable/associated.rb
index 4ecbd4c3ef..1792b6e7a1 100644
--- a/lib/mongoid/validatable/associated.rb
+++ b/lib/mongoid/validatable/associated.rb
@@ -74,7 +74,7 @@ def validate_association(document, attribute)
           # use map.all? instead of just all?, because all? will do short-circuit
           # evaluation and terminate on the first failed validation.
           list.map do |value|
-            if value && !value.flagged_for_destroy? && (!value.persisted? || value.changed?)
+            if value && !value.flagged_for_destroy?
               value.validated? ? true : value.valid?
             else
               true
diff --git a/spec/mongoid/association_spec.rb b/spec/mongoid/association_spec.rb
index 4477c80cf7..2ebeac80cd 100644
--- a/spec/mongoid/association_spec.rb
+++ b/spec/mongoid/association_spec.rb
@@ -115,6 +115,66 @@ class AssocationSpecModel
         expect(name).to_not be_an_embedded_many
       end
     end
+
+    context "validation tests on associated values" do
+      before(:all) do
+        class Author
+          include Mongoid::Document
+          embeds_many :books, cascade_callbacks: true
+          field :condition, type: Boolean
+        end
+
+        class Book
+          include Mongoid::Document
+          embedded_in :author
+          validate :parent_condition_is_not_true
+
+          def parent_condition_is_not_true
+            return unless author&.condition
+            errors.add :base, "Author condition is true."
+          end
+        end
+
+        Author.delete_all
+        Book.delete_all
+      end
+
+      let(:author) { Author.new }
+      let(:book) { Book.new }
+
+      context "when author is not persisted" do
+        it "is valid without books" do
+          expect(author.valid?).to be true
+        end
+
+        it "is valid with a book" do
+          author.books << book
+          expect(author.valid?).to be true
+        end
+
+        it "is not valid when condition is true with a book" do
+          author.condition = true
+          author.books << book
+          expect(author.valid?).to be false
+        end
+      end
+
+      context "when author is persisted" do
+        before do
+          author.books << book
+          author.save
+        end
+
+        it "remains valid initially" do
+          expect(author.valid?).to be true
+        end
+
+        it "becomes invalid when condition is set to true" do
+          author.update_attributes(condition: true)
+          expect(author.valid?).to be false
+        end
+      end
+    end
   end
 
   describe "#embedded_one?" do

From 340929fc158e80601722e0898427da4ba18ca2e9 Mon Sep 17 00:00:00 2001
From: Darshana Venkatesh <darshana.venkatesh@mongodb.com>
Date: Wed, 18 Dec 2024 09:05:36 -0800
Subject: [PATCH 2/2] change context statement to when

---
 spec/mongoid/association_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/mongoid/association_spec.rb b/spec/mongoid/association_spec.rb
index 2ebeac80cd..3850280e9b 100644
--- a/spec/mongoid/association_spec.rb
+++ b/spec/mongoid/association_spec.rb
@@ -116,7 +116,7 @@ class AssocationSpecModel
       end
     end
 
-    context "validation tests on associated values" do
+    context "when validation depends on association" do
       before(:all) do
         class Author
           include Mongoid::Document