MONGOID-5668 [Monkey Patch Removal] Remove String/Symbol#mongoid_id? (#…

…5703)

* Remove String#mongoid_id? and Symbol#mongoid_id?

* deprecate instead of remove

---------

Co-authored-by: Jamis Buck <[email protected]>

lib/mongoid/extensions/string.rb

@@ -71,9 +71,11 @@ def collectionize
       #   "_id".mongoid_id?
       #
       # @return [ true | false ] If the string is id or _id.
+      # @deprecated
       def mongoid_id?
         self =~ /\A(|_)id\z/
       end
+      Mongoid.deprecate(self, :mongoid_id?)
 
       # Is the string a number? The literals "NaN", "Infinity", and "-Infinity"
       # are counted as numbers.

lib/mongoid/extensions/symbol.rb

@@ -13,9 +13,11 @@ module Symbol
       #   :_id.mongoid_id?
       #
       # @return [ true | false ] If the symbol is :id or :_id.
+      # @deprecated
       def mongoid_id?
         to_s.mongoid_id?
       end
+      Mongoid.deprecate(self, :mongoid_id?)
 
       module ClassMethods
 

spec/mongoid/extensions/string_spec.rb

@@ -172,37 +172,6 @@ class Patient
     end
   end
 
-  describe "#mongoid_id?" do
-
-    context "when the string is id" do
-
-      it "returns true" do
-        expect("id").to be_mongoid_id
-      end
-    end
-
-    context "when the string is _id" do
-
-      it "returns true" do
-        expect("_id").to be_mongoid_id
-      end
-    end
-
-    context "when the string contains id" do
-
-      it "returns false" do
-        expect("identity").to_not be_mongoid_id
-      end
-    end
-
-    context "when the string contains _id" do
-
-      it "returns false" do
-        expect("something_id").to_not be_mongoid_id
-      end
-    end
-  end
-
   [ :mongoize, :demongoize ].each do |method|
 
     describe ".#{method}" do

spec/mongoid/extensions/symbol_spec.rb

@@ -5,37 +5,6 @@
 
 describe Mongoid::Extensions::Symbol do
 
-  describe "#mongoid_id?" do
-
-    context "when the string is id" do
-
-      it "returns true" do
-        expect(:id).to be_mongoid_id
-      end
-    end
-
-    context "when the string is _id" do
-
-      it "returns true" do
-        expect(:_id).to be_mongoid_id
-      end
-    end
-
-    context "when the string contains id" do
-
-      it "returns false" do
-        expect(:identity).to_not be_mongoid_id
-      end
-    end
-
-    context "when the string contains _id" do
-
-      it "returns false" do
-        expect(:something_id).to_not be_mongoid_id
-      end
-    end
-  end
-
   [ :mongoize, :demongoize ].each do |method|
 
     describe ".mongoize" do