abriters report as healthy (#740)

Author: zevisert

pkg/readiness/health/health.go

@@ -62,8 +62,7 @@ type StepStatus struct {
 }
 
 // isReadyState will return true, meaning a *ready state* in the sense that this Process can
-// accept read operations. There are no other states in which the MongoDB server could that
-// would mean a Ready State.
+// accept read operations.
 // It returns true if the managed process is mongos or standalone (replicationStatusUndefined)
 // or if the agent doesn't publish the replica status (older agents)
 func (h processHealth) IsReadyState() bool {
@@ -75,5 +74,15 @@ func (h processHealth) IsReadyState() bool {
 		return true
 	}
 
-	return status == replicationStatusPrimary || status == replicationStatusSecondary
+	switch status {
+	case
+		// There are no other states in which the MongoDB
+		// server could that would mean a Ready State.
+		replicationStatusPrimary,
+		replicationStatusSecondary,
+		replicationStatusArbiter:
+		return true
+	}
+
+	return false
 }

pkg/readiness/health/health_test.go

@@ -6,10 +6,10 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-// TestIsReadyState checks that Primary, Secondary and Undefined always result
+// TestIsReadyState checks that Primary, Secondary, Arbiter, and Undefined always result
 // in Ready State.
 func TestIsReadyStateNotPrimaryNorSecondary(t *testing.T) {
-	status := []replicationStatus{replicationStatusUndefined, replicationStatusPrimary, replicationStatusSecondary}
+	status := []replicationStatus{replicationStatusUndefined, replicationStatusPrimary, replicationStatusSecondary, replicationStatusArbiter}
 
 	for i := range status {
 		h := processHealth{ReplicaStatus: &status[i]}
@@ -21,7 +21,7 @@ func TestIsReadyStateNotPrimaryNorSecondary(t *testing.T) {
 func TestIsNotReady(t *testing.T) {
 	status := []replicationStatus{
 		replicationStatusStartup, replicationStatusRecovering, replicationStatusStartup2,
-		replicationStatusUnknown, replicationStatusArbiter, replicationStatusDown,
+		replicationStatusUnknown, replicationStatusDown,
 		replicationStatusRollback, replicationStatusRemoved,
 	}