implement dbshell #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In looking at https://www.mongodb.com/docs/mongodb-shell/write-scripts/, I don't see any advantage to using dbshell to execute JavaScript files. The JavaScript has to make its own connection to MongoDB... there's no way to use Django's connection. So let's omit that functionality. My guess is that most Python developers using Django will want to write Python scripts, not JavaScript! For the commit message, use: |
timgraham
approved these changes
May 8, 2024
django_mongodb/client.py
Outdated
|
|
||
| @classmethod | ||
| def settings_to_cmd_args_env(cls, settings_dict, parameters): | ||
| raise NotImplementedError | ||
| def settings_to_cmd_args_env(cls, settings_dict, parameters): # noqa: ARG003 parameters argument is not being used |
There was a problem hiding this comment.
I think we could shorten that a bit: # noqa: ARG003 parameters unused
django_mongodb/client.py
Outdated
|
|
||
| host = settings_dict["HOST"] | ||
| port = settings_dict["PORT"] | ||
| dbname = settings_dict["NAME"] or "test" |
There was a problem hiding this comment.
remove "test" now that parameters are gone
fixes #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of MongoDB connection setup method in DatabaseClient class.
Description:
This PR introduces the
settings_to_cmd_args_envmethod in theDatabaseClientclass.Limitations:
awsIamSessionToken.Feedback and contributions are welcomed to address these limitations and refine the implementation.