add support for partial indexes #159
Conversation
And also creating uniques in create_model() and add_field(), and removing them in remove_field().
| where = query.build_where(self.condition) | ||
| compiler = query.get_compiler(connection=schema_editor.connection) | ||
| mql_ = where.as_mql(compiler, schema_editor.connection) | ||
| # Transform aggregate() query syntax into find() syntax. |
There was a problem hiding this comment.
This stinks and doesn't work for multiple conditions / null conditions (but maybe could be done). I wonder if it would be better to have a separate path from as_mql() to generate find() compatible MQL rather than trying to convert from the aggregate syntax.
There was a problem hiding this comment.
As I understand it, we're pulling the index conditions from a model's field definitions using the compiler built by the schema editor? Is this schema_editor compiler different from our Mongo one?
can self.condition ever be a list of items?
Speaking more broadly, I'd say, yes, let's include the find compatible conversions, but how many nodes/expressions would we need that for? Also, since find is much more limited there would still be gaps.
There was a problem hiding this comment.
query.get_compiler() is the same compiler we use for other queries.
condition is a Q object: "For example, condition=Q(pages__gt=400) indexes records with more than 400 pages."
What doesn't currently work is multiple conditions like:
Q(
pub_date__gt=datetime.datetime(
year=2015,
month=1,
day=1,
tzinfo=timezone.get_current_timezone(),
)
)
& Q(headline__contains="China")Maybe that can be translated without too much difficulty. I didn't think about it too much.
Obviously, we can only support conditions that MongoDB supports.
timgraham
force-pushed
the
partial-indexes
branch
from
07e5a17
to
575957c
Compare
| if unique: | ||
| kwargs["unique"] = True | ||
| if field: | ||
| filter_expression[field.column].update({"$type": field.db_type(self.connection)}) |
There was a problem hiding this comment.
do we need to maintain type? if so, why?
There was a problem hiding this comment.
The comment is below: "Use partialFilterExpression to allow multiple null values for a unique constraint." It's not really in the best spot and should be amended to reference $type since partialFilterExpression is also used for condition.
| where = query.build_where(self.condition) | ||
| compiler = query.get_compiler(connection=schema_editor.connection) | ||
| mql_ = where.as_mql(compiler, schema_editor.connection) | ||
| # Transform aggregate() query syntax into find() syntax. |
There was a problem hiding this comment.
As I understand it, we're pulling the index conditions from a model's field definitions using the compiler built by the schema editor? Is this schema_editor compiler different from our Mongo one?
can self.condition ever be a list of items?
Speaking more broadly, I'd say, yes, let's include the find compatible conversions, but how many nodes/expressions would we need that for? Also, since find is much more limited there would still be gaps.
refs #104