Skip to content

Commit 0cfd746

Browse files
feat(data-modeling): integrate diagramming package COMPASS-9357 (#6979)
* diagramming * diagramming * edges * npm install * remove relationship * correct type * bootstrap * no lock changes * npm i * main lock file * checkout lock from main * npm install * add todo and show cardinality * npm run check * update diagramming * bump package * bump package * undo webpack changes * missing importexports warning * npm i * fix tests * npm i * fix dev version * correct func name * clean up tests * npm i * clean up * bump diagramming * wait for diagram animations --------- Co-authored-by: Paula Stachova <[email protected]>
1 parent 848fe48 commit 0cfd746

File tree

9 files changed

+846
-134
lines changed

9 files changed

+846
-134
lines changed

.evergreen/print-compass-env.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ if [[ "${EVERGREEN_PROJECT}" == "10gen-compass-main" ]]; then
4343
month=$(escapeLeadingZero "${ts[1]}")
4444
day=$(escapeLeadingZero "${ts[2]}")
4545
hour=$(escapeLeadingZero "${ts[3]}")
46-
minute="${ts[4]}"
47-
second="${ts[5]}"
46+
minute=$(escapeLeadingZero "${ts[4]}")
47+
second=$(escapeLeadingZero "${ts[5]}")
4848
export DEV_VERSION_IDENTIFIER="${year}.${month}.${day}-dev.${hour}${minute}${second}"
4949
fi
5050
fi

configs/webpack-config-compass/src/index.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,17 @@ export function createElectronMainConfig(
147147
sharedObjectLoader(opts),
148148
sourceLoader(opts),
149149
],
150+
parser: {
151+
javascript: {
152+
// Webpack compile time check for imports matching exports is too strict
153+
// in cases where the code expects some name export to be optional
154+
// (webpack will break the build if it fails to statically see the
155+
// matching export) this is why we switch the check to just warn. If
156+
// this ever hides a real case where a missing import is being used, it
157+
// will definitely break in runtime anyway
158+
importExportsPresence: 'warn' as const,
159+
},
160+
},
150161
},
151162
node: false as const,
152163
externals: toCommonJsExternal(sharedExternals),
@@ -218,6 +229,11 @@ export function createElectronRendererConfig(
218229
sharedObjectLoader(opts),
219230
sourceLoader(opts),
220231
],
232+
parser: {
233+
javascript: {
234+
importExportsPresence: 'warn' as const,
235+
},
236+
},
221237
},
222238
plugins: [
223239
...entriesToHtml(entries),
@@ -338,6 +354,11 @@ export function createWebConfig(args: Partial<ConfigArgs>): WebpackConfig {
338354
assetsLoader(opts),
339355
sourceLoader(opts),
340356
],
357+
parser: {
358+
javascript: {
359+
importExportsPresence: 'warn' as const,
360+
},
361+
},
341362
},
342363
// This follows current Compass plugin behavior and is here more or less to
343364
// keep compat for the external plugin users

0 commit comments

Comments
 (0)