✨ add ability to fetch ms365 application by id #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaym
reviewed
Jan 15, 2025
| } | ||
| name := raw.Value.(string) | ||
| if appId == "" { | ||
| raw, ok := args["id"] |
There was a problem hiding this comment.
should id take precedence if both are specified
There was a problem hiding this comment.
right now we're assuming that only one will be provided/are rejecting if more than one provided. but ya, if we got both it would be better it would be better to use id
|
should there be changes to the resource definition file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow users to fetch by name or id