Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make callback-version of sendIq return AnyPromise #1219

Open
2 tasks done
tmolitor-stud-tu opened this issue Aug 27, 2024 · 0 comments
Open
2 tasks done

[Feature]: Make callback-version of sendIq return AnyPromise #1219

tmolitor-stud-tu opened this issue Aug 27, 2024 · 0 comments
Labels
🦸 Help wanted If you are motivated, this is a good start!

Comments

@tmolitor-stud-tu
Copy link
Member

Precondition

  • I understood that this template is only for feature requests and not for bug reports

Cross-checked related issues?

Describe your feature

Replace the success and error callbacks provided to xmpp.m's sendIq: let sendIq return AnyPromise instead.

To resolve that properly, any error IQ must conform to NSError, too. This is needed to make PromiseKit call the attached error handler of the promise instead of the success handler.

@tmolitor-stud-tu tmolitor-stud-tu added the 🦸 Help wanted If you are motivated, this is a good start! label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦸 Help wanted If you are motivated, this is a good start!
Projects
Status: Todo
Development

No branches or pull requests

1 participant