Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Reconcilation Statuses #141

Closed
3 tasks done
gluax opened this issue Apr 26, 2024 · 1 comment
Closed
3 tasks done

♻️ Reconcilation Statuses #141

gluax opened this issue Apr 26, 2024 · 1 comment
Assignees
Labels
Monadic.us All items Assigned to or Created by Monadic.us

Comments

@gluax
Copy link
Contributor

gluax commented Apr 26, 2024

For the reconciliation process what we should instead do is:

  • agent reconcile RPC is short lived and returns an error, a requeue duration + status messages, or an OK
  • control plane has a global reconcile loop that walks a reconcile queue
  • env prepare (now apply) queues a reconcile for every agent

reasons:

  • current reconcile logic dies if the rest request is closed
  • current reconcile logic depends on long lived RPC contexts
  • current reconcile logic does not showing show clear status
  • new reconcile can show where things fail
  • new reconcile has better code smell (a Reconcile trait or something and more modular code)
  • new reconcile concepts are more battle tested in devops land
@gluax gluax added the Monadic.us All items Assigned to or Created by Monadic.us label Apr 26, 2024
@Slickbird Slickbird changed the title [Refactor]: Reconcilation Statuses ♻️ Reconcilation Statuses May 8, 2024
@gluax gluax mentioned this issue Jun 6, 2024
6 tasks
@gluax gluax assigned voximity and unassigned Meshiest and voximity Jun 6, 2024
@Meshiest
Copy link
Contributor

Meshiest commented Dec 6, 2024

completed in #315

@Meshiest Meshiest closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monadic.us All items Assigned to or Created by Monadic.us
Projects
None yet
Development

No branches or pull requests

4 participants