Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing endpoint payments of payment-links #381

Open
mattickx opened this issue Sep 26, 2024 · 2 comments
Open

Missing endpoint payments of payment-links #381

mattickx opened this issue Sep 26, 2024 · 2 comments
Labels
API extension Previously missing endpoints/binders.
Milestone

Comments

@mattickx
Copy link

Add missing endpoint https://api.mollie.com/v2/payment-links/{id}/payments to the mollie node client.

Docs:
https://docs.mollie.com/reference/get-payment-link-payments

Related discord topics:
https://discord.com/channels/1037712581407817839/1288507180122640456
https://discord.com/channels/1037712581407817839/1288137318691242058
https://discord.com/channels/1037712581407817839/1166419761060646942
https://discord.com/channels/1037712581407817839/1057291926786801735

As requested by Flo on discord, adding it here as an issue to keep track of it.

Maybe worth it to document which endpoints are missing.
Or at least implement it with a throw throw new Error('Not yet implemented')

@fjbender fjbender added the API extension Previously missing endpoints/binders. label Sep 27, 2024
@fjbender
Copy link
Contributor

Maybe possible to squeeze in https://github.com/mollie/mollie-api-node/milestone/6, too @Pimm?

@janpaepke
Copy link
Collaborator

The main extension currently for 4.2.0 is the addition of the terminals API.
This one is far more extensive but it still might make sense to do it in the same release.
I will mark it for 4.2.0 for now, but suggest to bump it to 4.3.0 if this turns out to significantly delay the release.

Please also be advised that there is currently no fixed schedule for 4.2.0

@mattickx: We strive to keep the client as up to date as possible. The added overhead of managing missing or disabled endpoints in the code often is on par or even exceeds the efforts needed to just implement them for real. This is why we generally try to avoid this.

@janpaepke janpaepke added this to the 4.2.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API extension Previously missing endpoints/binders.
Projects
None yet
Development

No branches or pull requests

3 participants