Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new 'Terminals' API #328

Open
Jeffrey-Zutt opened this issue Sep 7, 2023 · 7 comments
Open

The new 'Terminals' API #328

Jeffrey-Zutt opened this issue Sep 7, 2023 · 7 comments
Labels
API extension Previously missing endpoints/binders.
Milestone

Comments

@Jeffrey-Zutt
Copy link

Jeffrey-Zutt commented Sep 7, 2023

Hello!

First off all, thanks for maintaining this great library :-).

I was wondering if there are any plans of integrating the new 'terminals' API into this library.
https://docs.mollie.com/reference/v2/terminals-api/overview

Happy to help and raise a PR on it.

@fjbender
Copy link
Contributor

fjbender commented Sep 7, 2023

Thanks for reaching out! We're always happy to take contributions :)

Once the resource issue on the Terminal API is covered, let's take another look at this.

@Jeffrey-Zutt
Copy link
Author

Yeah I noticed that too, the resource property is missing from the actual API response right?
(Even though it's documented here: https://docs.mollie.com/reference/v2/terminals-api/get-terminal#response)

Do you happen to have any idea when this issue will be covered? (Ballpark?)

@fjbender
Copy link
Contributor

fjbender commented Sep 7, 2023

I have just been informed that one of our fantastic engineers has fixed it already :) Should be available very shortly.

if you were to provide a PR, @Pimm and I would be very happy, I'm sure. I will be out of the office for a while, but @Jonas4Mollie will keep watch.

@Jeffrey-Zutt
Copy link
Author

Awesome! I'll keep you posted :-)

@Jonas4Mollie
Copy link

The resource parameter is now part of the API response, so you should be able to move ahead!

@iFlyinq
Copy link

iFlyinq commented Mar 25, 2024

Any updates on this one?

@janpaepke janpaepke added the API extension Previously missing endpoints/binders. label Sep 11, 2024
@janpaepke
Copy link
Collaborator

addition is planned for 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API extension Previously missing endpoints/binders.
Projects
None yet
Development

No branches or pull requests

5 participants