-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency on phoenix_ecto #475
Comments
This is the first time a report like this has come in. Could you provide a minimal I'm inferring that you are running a Phoenix project, and using Ecto, but decided to manually not use phoenix_ecto on that project as well? |
Sure! Here you go: https://github.com/axelson/torch_repro_phoenix_ecto Yeah it isn't a common setup. In my actual project I generated an ecto-only project, then sometime later I decided I wanted a web frontend for it so I generated a separate phoenix project for it, but at that time it was only for visualization so I didn't realize that I hadn't added |
OK, let me look at this and consider it. Torch was (is currently) only intended to be used on a Phoenix project as it depends quite heavily (as you found out) on Phoenix and its feature libraries. I'm not sure we want to fully decouple that. We may end up just adding a note to the README docs about the issue you found. |
Yeah I'm definitely not suggesting to decouple Torch from Phoenix. Just mentioning a part of Phoenix that Torch depends on implicitly (and hoping to make it slightly more explicit). |
In the Readme and mix.exs there's no mention of
phoenix_ecto
but trying to edit a resource withoutphoenix_ecto
loaded results in an exception like:Adding a dep like
{:phoenix_ecto, "~> 4.6"}
to your projectsmix.exs
fixes this error.To resolve this I think either ensuring
:phoenix_ecto
is installed to the Readme, or directly depend on:phoenix_ecto
in Torch'smix.exs
.The text was updated successfully, but these errors were encountered: