Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

god cannot be used with Ruby 3.1+ #263

Open
mishina2228 opened this issue Jan 9, 2022 · 4 comments · May be fixed by #262
Open

god cannot be used with Ruby 3.1+ #263

mishina2228 opened this issue Jan 9, 2022 · 4 comments · May be fixed by #262

Comments

@mishina2228
Copy link

mishina2228 commented Jan 9, 2022

Condition:

  • Using Ruby: 3.1+

OR

  • Using timeout 0.2.0+

I'm using Ruby 3.0.2 and timeout 0.2.0. (Default is 0.1.1, but I've updated it.)
refs: #262 (comment)

E [2022-01-09 00:31:15] ERROR: Unhandled exception in ProcessRunning condition - (NoMethodError): undefined method `timeout' for God::System::SlashProcPoller:Class
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/system/slash_proc_poller.rb:64:in `readable?'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/system/slash_proc_poller.rb:18:in `block in usable?'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/system/slash_proc_poller.rb:17:in `all?'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/system/slash_proc_poller.rb:17:in `usable?'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/system/process.rb:6:in `fetch_system_poller'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/system/process.rb:15:in `initialize'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/conditions/process_running.rb:46:in `new'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/conditions/process_running.rb:46:in `test'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/task.rb:367:in `handle_poll'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/driver.rb:64:in `handle_event'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/driver.rb:181:in `block (2 levels) in initialize'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/driver.rb:179:in `loop'
/home/owner/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/god-0.13.7/lib/god/driver.rb:179:in `block in initialize'

#262 will solve this problem.

@mishina2228 mishina2228 linked a pull request Jan 9, 2022 that will close this issue
@mishina2228 mishina2228 changed the title god cannot be used with Rails 3.0 god cannot be used with Ruby 3.0 Jan 11, 2022
@mishina2228 mishina2228 changed the title god cannot be used with Ruby 3.0 god cannot be used with Ruby 3.0+ Jan 11, 2022
@mishina2228 mishina2228 changed the title god cannot be used with Ruby 3.0+ god cannot be used with Ruby 3.1+ Jul 7, 2022
@Rajesh1213
Copy link

Hi @mishina2228, This fix was merged on May 2, 2023. We are planning to use this gem with Ruby 3.2.2. Considering the issue is still in an open state, should I consider it resolved and proceed? Or are there any aspects you are still examining?

@mishina2228
Copy link
Author

@Rajesh1213 I assume that you are talking about abak-press#3, but it's a forked project and has nothing todo with this project.

@Rajesh1213
Copy link

Oh, my bad. It was a mention. I wrongly understood the mention as merged. @mishina2228

@bshand
Copy link

bshand commented Jun 27, 2024

A forked version of this gem has been released, resurrected_god, with homepage https://github.com/mishina2228/resurrected_god. It's a drop-in replacement for god which includes this fix and supports ruby 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants