Skip to content

Commit 68075c9

Browse files
committed
Refer to the FAQ if a log message has an entry
1 parent e87091a commit 68075c9

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

Changes

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11

2-
9.33 2023-05-10
2+
9.33 2023-05-15
3+
- Improved log messages to refer to the FAQ when they have an entry.
34

45
9.32 2023-05-09
56
- Improved file and line number details in async/await exceptions. (batman)

lib/Mojo/Server/Daemon.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ sub _listen {
200200
$stream->on(close => sub { $self && $self->_close($id) });
201201
$stream->on(error => sub { $self && $self->app->log->error(pop) && $self->_close($id) });
202202
$stream->on(read => sub { $self->_read($id => pop) });
203-
$stream->on(timeout => sub { $self->_trace($id, 'Inactivity timeout') });
203+
$stream->on(timeout => sub { $self->_trace($id, 'Inactivity timeout (see FAQ for more)') });
204204
}
205205
);
206206

lib/Mojo/Server/Prefork.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ sub _manage {
110110
next unless my $w = $self->{pool}{$pid};
111111

112112
# No heartbeat (graceful stop)
113-
$log->error("Worker $pid has no heartbeat ($ht seconds), restarting") and $w->{graceful} = $time
113+
$log->error("Worker $pid has no heartbeat ($ht seconds), restarting (see FAQ for more)") and $w->{graceful} = $time
114114
if !$w->{graceful} && ($w->{time} + $interval + $ht <= $time);
115115

116116
# Graceful stop with timeout

lib/Mojolicious.pm

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ has secrets => sub {
4545
my $self = shift;
4646

4747
# Warn developers about insecure default
48-
$self->log->trace('Your secret passphrase needs to be changed');
48+
$self->log->trace('Your secret passphrase needs to be changed (see FAQ for more)');
4949

5050
# Default to moniker
5151
return [$self->moniker];
@@ -141,7 +141,8 @@ sub handler {
141141
$self->plugins->emit_chain(around_dispatch => $c);
142142

143143
# Delayed response
144-
$c->helpers->log->trace('Nothing has been rendered, expecting delayed response') unless $c->stash->{'mojo.rendered'};
144+
$c->helpers->log->trace('Nothing has been rendered, expecting delayed response (see FAQ for more)')
145+
unless $c->stash->{'mojo.rendered'};
145146
}
146147

147148
sub helper { shift->renderer->add_helper(@_) }

0 commit comments

Comments
 (0)