Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoteResponseId on quoteExtension table should be nullable #174

Open
bushjames opened this issue Mar 25, 2020 · 2 comments
Open

quoteResponseId on quoteExtension table should be nullable #174

bushjames opened this issue Mar 25, 2020 · 2 comments
Assignees

Comments

@bushjames
Copy link
Contributor

Currently the quoteResponseId column of the quoteExtension table is not nullable meaning rows cannot be inserted to record quote request extensions; a quote response will not have been recorded at that stage. This column needs to be nullable in order to allow extensionList items on quote requests to be recorded.

@bushjames bushjames self-assigned this Mar 25, 2020
@bushjames
Copy link
Contributor Author

Note that the knex migrations that create this table are in mojaloop/central-ledger repo. PR will be raised there to correct this issue.

@mdebarros
Copy link
Member

Note that the knex migrations that create this table are in mojaloop/central-ledger repo. PR will be raised there to correct this issue.

@bushjames was this resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants