Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the closing of a Settlement Matrix in order to close a matrix without settling at the same time #3265

Closed
5 tasks done
koekiebox opened this issue Mar 31, 2023 · 0 comments
Assignees
Labels
vNext vNext Platform Development (inline with RefArch) vNext-Settlement Stories and tasks related to the new Mojaloop Settlement component.

Comments

@koekiebox
Copy link

koekiebox commented Mar 31, 2023

Goal:

As a hub operator

I want to be able to CLOSE a batch

so that a batch may be closed without actioning the settling action, which will allow a hub operator to alternatively dispute a CLOSED batch

Acceptance Criteria:

  • Refactor closeSettlementMatrix to only mark batches as CLOSED and not perform the settlement action
  • Introduce executeSettlementMatrix which will mark batches for a matrix as CLOSED and SETTLED (perform the settlement action)
  • Add domain unit tests to cover the above scenarios
  • Introduce negative test cases

Complexity: <Medium>

Uncertainty: <Low> N/A.


Tasks:
Currently when closeSettlementMatrix(secCtx: CallSecurityContext, id: string): Promise<void> { function is invoked, the settlement batches will be closed as well as the settling process kicked off.
Instead, the closeSettlementMatrix(secCtx: CallSecurityContext, id: string): Promise<void> { should only CLOSE the batches for a matrix.

A new function called executeSettlementMatrix(secCtx: CallSecurityContext, id: string): Promise<void> { should be introduced, which should:

  • Close any of the OPEN batches for the matrix
  • Process the settling for the batches

Background:

Please see: mojaloop/mojaloop-specification#117

Done

  • Tests coverage is adequate

Pull Requests:

mojaloop/settlements-bc#6

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

@koekiebox koekiebox self-assigned this Mar 31, 2023
@koekiebox koekiebox added vNext vNext Platform Development (inline with RefArch) vNext-Settlement Stories and tasks related to the new Mojaloop Settlement component. story labels Mar 31, 2023
@koekiebox koekiebox removed the story label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vNext vNext Platform Development (inline with RefArch) vNext-Settlement Stories and tasks related to the new Mojaloop Settlement component.
Projects
None yet
Development

No branches or pull requests

1 participant