You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on the names of the following two variables I think the line comments are wrong:
variable_cooling_tube_position
variable_cooling_tube_length
Example:
variable_cooling_tube_position should have the comment: Measured from Nozzle to Top of Heater Block
variable_cooling_tube_length should have the comment: Measured from Top of Heater Block to Top of Heatsink
The text was updated successfully, but these errors were encountered:
I need to find a moment to carefully review the tip forming code/comments. That text was part of a PR and it "looked right" to me at the time.
From memory (not looking at the macro at the moment) are you sure that cooling_tube_position isn't the middle of the distance from top of heater to top of heatsink? (I need to double check the actual macro movement)
Based on the names of the following two variables I think the line comments are wrong:
variable_cooling_tube_position
variable_cooling_tube_length
Example:
variable_cooling_tube_position should have the comment: Measured from Nozzle to Top of Heater Block
variable_cooling_tube_length should have the comment: Measured from Top of Heater Block to Top of Heatsink
The text was updated successfully, but these errors were encountered: