Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading line comments #91

Open
ssackett opened this issue Aug 10, 2023 · 1 comment
Open

Misleading line comments #91

ssackett opened this issue Aug 10, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@ssackett
Copy link

Based on the names of the following two variables I think the line comments are wrong:
variable_cooling_tube_position
variable_cooling_tube_length

Example:
variable_cooling_tube_position should have the comment: Measured from Nozzle to Top of Heater Block
variable_cooling_tube_length should have the comment: Measured from Top of Heater Block to Top of Heatsink

@moggieuk
Copy link
Owner

I need to find a moment to carefully review the tip forming code/comments. That text was part of a PR and it "looked right" to me at the time.

From memory (not looking at the macro at the moment) are you sure that cooling_tube_position isn't the middle of the distance from top of heater to top of heatsink? (I need to double check the actual macro movement)

@moggieuk moggieuk added the help wanted Extra attention is needed label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants