Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#7401: Implement DataFrame/Series.attrs #7402

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

FEAT-#7401: Implement DataFrame/Series.attrs #7402

wants to merge 1 commit into from

Conversation

noloerino
Copy link
Collaborator

What do these changes do?

[STILL A DRAFT] Implement df.attrs by annotating relevant functions with a new @propagate_self_attrs annotation that automatically copies self._attrs if the result is detected to be a new DataFrame/Series.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Writes to DataFrame.attrs are not preserved #7401
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 24, 2024
View reviewed changes
modin/pandas/base.py
@@ -16,6 +16,8 @@
from __future__ import annotations

import abc
import copy
import functools

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note

Module 'functools' is imported with both 'import' and 'import from'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn will be requested when the pull request is marked ready for review devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha will be requested when the pull request is marked ready for review mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD will be requested when the pull request is marked ready for review RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev will be requested when the pull request is marked ready for review YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov will be requested when the pull request is marked ready for review vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev will be requested when the pull request is marked ready for review anmyachev is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev will be requested when the pull request is marked ready for review dchigarev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Writes to DataFrame.attrs are not preserved
1 participant
@noloerino