Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#7387: Limit the number of pytest workers for tests with Ray engine on Windows #7388

Merged
merged 1 commit into from
Sep 6, 2024
Merged

FIX-#7387: Limit the number of pytest workers for tests with Ray engine on Windows #7388

merged 1 commit into from
Sep 6, 2024

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Sep 6, 2024 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves CI tests are failing with Ray engine on Windows using multiple pytest workers #7387
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev
FIX-modin-project#7387: Limit the number of pytest workers for tests …
51e5faf 
…with Ray engine on Windows

Signed-off-by: Igoshev, Iaroslav <[email protected]>
@YarShev YarShev changed the title FIX-#7387: Limit the number of pytest workers for tests with Ray engi… FIX-#7387: Limit the number of pytest workers for tests with Ray engine on Windows Sep 6, 2024
@YarShev
Copy link
Collaborator Author

YarShev commented Sep 6, 2024

Tests with Ray engine on Windows passed - https://github.com/YarShev/modin/actions/runs/10740110702.

@anmyachev anmyachev merged commit f3c0a63 into modin-project:main Sep 6, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmyachev anmyachev anmyachev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI tests are failing with Ray engine on Windows using multiple pytest workers
2 participants
@YarShev @anmyachev