Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMUChecker missing check for optional authority in fmuResourceLocation URI #389

Closed
modelica-trac-importer opened this issue Oct 17, 2018 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@modelica-trac-importer
Copy link

Reported by lausdahl on 28 Oct 2016 18:03 UTC
The FMUChecker does not check if the FMU respects the FMI standard concerning the fmuResourceLocation URI for the instantiate call.

The check must check that instantiate can be called with the scheme file and a fully qualified path both with and without the authority as described in the standard:

Argument fmuResourceLocation is an URI according to the IETF RFC3986 syntax to
indicate the location to the “resources” directory of the unzipped FMU archive. The
following schemes must be understood by the FMU:
• Mandatory: file with absolute path (either including or omitting the authority component)
• Optional: http, “https”, “ftp”
• Reserved: fmi2 for FMI for PLM.

The FMU checker only tries to call it with authority. e.g. "file:///C:/temp/MyFMU/resources but it should also check that "file:/C:/temp/MyFMU/resources is accepted.

The defect was discovered when exported FMUs for the FMI standard version 2 was exported from FMI Toolbox for MATLAB/Simulink version 2.3.3 where the FMU checker reported that the FMU was ok. This as shown in the tool site for FMI.

However, they are not compliant because they only support the fmuResourceLocation with empty authority but the standard states that they must support an URI where the authority is left out.


Migrated-From: https://trac.fmi-standard.org/ticket/389

@modelica-trac-importer modelica-trac-importer added this to the Checker 2.0.1 milestone Oct 17, 2018
@modelica-trac-importer modelica-trac-importer added bug Something isn't working P: major labels Oct 17, 2018
@modelica-trac-importer
Copy link
Author

Modified by andreas.junghanns on 28 Oct 2016 18:59 UTC

@modelica-trac-importer
Copy link
Author

Comment by cbertsch on 1 Jun 2018 19:07 UTC
Moved to modelica-tools/FMUComplianceChecker#33

@modelica-trac-importer modelica-trac-importer added the duplicate This issue or pull request already exists label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants