Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tolerance of tube in y-axis #34

Open
JohanYli opened this issue Apr 20, 2016 · 2 comments
Open

Set tolerance of tube in y-axis #34

JohanYli opened this issue Apr 20, 2016 · 2 comments

Comments

@JohanYli
Copy link

I am working with a set of signals of varying magnitude where one signal is very small (and very small variation). Since there seem to be some limitation on the ratio of sides of the rectangle used to calculate the tube (I saw a max statement with 0.0004 in the ratio calculation) this allows really big relative differences of small results.

As I understand the setting of tolerance, it only affects the width of the tube on the x-axis, is there a way to specify the width of the tube on the y-axis instead? Preferably on a signal-to-signal basis (not all signals are small). Or can you improve the tube algorithm, there seems to be an attempt to this in the function 'SetStandardBaseAndRatio' in Modelica_ResultCompare/CurveCompare/TubeSize.cs but for some reason 'SetFormerBaseAndRatio' is used instead.

@bastianbin
Copy link
Contributor

Hi Johan,

If I am not mistaken, the CurveCompare (which contains the algorithms used in CSVCompare) already supports setting both the tolerance on x- and y-axis. This feature has not been passed through to the command line interface, however.

I also intend on adding this but cannot give you a time frame when I will get to it. But yes, this would be nice to have.

Best,
bastian

@beutlich
Copy link
Collaborator

There also is some discussion going on in modelica/ModelicaStandardLibrary#4421 for how to introduce the concept of nominal values.

FYI @casella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants