Skip to content
This repository has been archived by the owner on Dec 28, 2024. It is now read-only.

Annotation with relative Include/Library directories #3

Closed
PMehrfeld opened this issue Dec 7, 2016 · 4 comments
Closed

Annotation with relative Include/Library directories #3

PMehrfeld opened this issue Dec 7, 2016 · 4 comments

Comments

@PMehrfeld
Copy link
Contributor

PMehrfeld commented Dec 7, 2016

We are aiming to use the NcDataReader2 library in the AixLib (RWTH-EBC/AixLib#313). Since we found some improvement regarding the annotation to include external files, it is not necessary anylonger to copy the files into the working directory.
The annotation is like:
Include = "#include <ncDataReaderEA.h>", IncludeDirectory = "modelica://NcDataReader2/Resources/Include",
Especially the ...Directory commands are not implemented in the current master.
Similar, but with focus on 32 bit, is done in BuildingSystems: https://github.com/UdK-VPT/BuildingSystems/blob/master/BuildingSystems/Utilities/NcDataReader2/ncEasyGet1D.mo

Additionally, due to the 32/64 bit folder structure, the correct files will be chosen.
This was tested with Dymola 2017.

We could also create our own solution like in BuildingSystems. But in my opinion it is better to keep the dependency to this repo in order to stay up to date.

Is it okay, if we fork a branch and make a PR afterwards?

@tbeu
Copy link
Contributor

tbeu commented Dec 7, 2016

Is it okay, if we fork a branch and make a PR afterwards?

Sure, that's the way OSS contribution works and is stated in the readme file. Thanks!

@PMehrfeld
Copy link
Contributor Author

Thanks for merging.
I close this issue due to #4

@thorade
Copy link
Contributor

thorade commented Dec 8, 2016

Minor comment @PMehrfeld :
All the links in your text are broken, you can just paste any URL as text and it will be converted:
RWTH-EBC/AixLib#313
https://github.com/UdK-VPT/BuildingSystems/blob/master/BuildingSystems/Utilities/NcDataReader2/ncEasyGet1D.mo
This will also create the backlinks in the other issues.

@tbeu
Copy link
Contributor

tbeu commented Dec 8, 2016

@thorade Links are fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants