New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weather-server-typescript dir includes build and node_modules dirs, no .gitignore #3

Open

hideya opened this issue Jan 4, 2025 · 0 comments

Labels

bug

Contributor

hideya commented Jan 4, 2025 •

edited

Loading

Describe the bug

There is no .gitignore included in the weather-server-typescript dir
build and node_modules dirs have been committed unnecessarily
The author may have intended to make this repo to be executable as is, but I think including those dirs is a bit much... Instead, the need for npm install and npm run build could have been explained in README.md

To Reproduce
Steps to reproduce the behavior:

make a clean clone
ls weather-server-typescript

Expected behavior

Add appropriate .gitignore and avoid committing of build and node_modules dirs.

Logs
N/A

Additional context
Thanks for sharing the finished code!

The text was updated successfully, but these errors were encountered:

hideya added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment