New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not skip auto now fields but assign with specified value #520

Open

mattwang44 wants to merge 1 commit into model-bakers:main from mattwang44:fix-#519

+53 −6

Contributor

mattwang44 commented Feb 22, 2025 •

edited

Loading

Describe the change
Fix #519, which is a regression introduced in #507.

The auto now fields should be skipped in _skip_field(). Instead, assign the specified value to the resulting instance.
Add test cases (modified from those provided by @hoefling in #519).

PR Checklist

Change is covered with tests
CHANGELOG.md is updated if needed

mattwang44 force-pushed the fix-#519 branch 5 times, most recently from 765364b to 3353a8c Compare

February 22, 2025 15:15


          fix: should not skip auto now fields but assign with specified value

fedfb1e

mattwang44 force-pushed the fix-#519 branch from 3353a8c to fedfb1e Compare

February 22, 2025 15:23

mattwang44 marked this pull request as draft

February 22, 2025 15:23

mattwang44 marked this pull request as ready for review

February 22, 2025 15:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet