Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version string in mod_proxy_cluster.h #243

Open
rhusar opened this issue Jul 2, 2024 · 3 comments
Open

Update the version string in mod_proxy_cluster.h #243

rhusar opened this issue Jul 2, 2024 · 3 comments

Comments

@rhusar
Copy link
Member

rhusar commented Jul 2, 2024

https://github.com/modcluster/mod_proxy_cluster/blob/main/native/include/mod_proxy_cluster.h#L21

Side question: can we include the git hash somehow?

@rhusar
Copy link
Member Author

rhusar commented Jul 3, 2024

Note that the version is available via VERSION command - https://github.com/modcluster/mod_proxy_cluster/blob/main/native/mod_manager/mod_manager.c#L2384

So we need to make sure the name is correctly consumed, although, I don't think this is available / used anywhere (officially) yet.

@jajik
Copy link
Collaborator

jajik commented Jul 18, 2024

related to #246

@jajik
Copy link
Collaborator

jajik commented Oct 14, 2024

Once we release the beta, should we update the name as well (mod_cluster -> mod_proxy_cluster)? Because we discussed the versioning policy only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants