-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I use Firefox, I should see the sprites. #10
Comments
Css masks only work with a vendor prefix in webkit browsers (Chrome, Safari, etc.) and in Firefox only work with inline svg, instead of a link to an image. (http://caniuse.com/#feat=css-masks) |
Yeah, I think you're totally right. So we need to update the React entity to include the vendor-specific styles, not just the vanilla styles. |
Either that, or switch from CSS Masks to CSS Color Rotates, or do the stupid lazy thing and color the sprites by canvas. |
My vote it to switch to the stupid lazy thing until Mozilla realizes it's 2016 and that they need to properly implement CSS masks. It looks like Webkit has had them since 2008 (https://webkit.org/blog/181/css-masks/). ¯_(ツ)_/¯ |
Details
We are, for all intents and purposes, supporting primarily Chrome, mostly because we'll be bundling our code via Electron, which is really just Chromium. However, it would be nice if it worked (more or less) on most (or at least a few) other browsers. Such as Firefox.
When opening our game in Firefox, all our sprites are just boxes.
Screenshot

### ImplementationWe're using
-webkit-mask
, which is (obviously) unique to Webkit. We need to either add declarations for other vendor-specific masks, or figure out whymask
isn't working in React.The text was updated successfully, but these errors were encountered: