Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I use Firefox, I should see the sprites. #10

Open
ehgoodenough opened this issue Mar 7, 2016 · 4 comments
Open

When I use Firefox, I should see the sprites. #10

ehgoodenough opened this issue Mar 7, 2016 · 4 comments
Labels

Comments

@ehgoodenough
Copy link
Member

Details

We are, for all intents and purposes, supporting primarily Chrome, mostly because we'll be bundling our code via Electron, which is really just Chromium. However, it would be nice if it worked (more or less) on most (or at least a few) other browsers. Such as Firefox.

When opening our game in Firefox, all our sprites are just boxes.

Screenshot

screen shot 2016-03-06 at 9 59 51 pm

### Implementation

We're using -webkit-mask, which is (obviously) unique to Webkit. We need to either add declarations for other vendor-specific masks, or figure out why mask isn't working in React.

@ehgoodenough ehgoodenough reopened this Sep 7, 2016
@ehgoodenough ehgoodenough changed the title When I use Firefox, I should see the shapes. When I use Firefox, I should see the sprites, not just boxes. Sep 7, 2016
@ehgoodenough ehgoodenough changed the title When I use Firefox, I should see the sprites, not just boxes. When I use Firefox, I should see the sprites. Sep 7, 2016
@Willamin
Copy link
Contributor

Css masks only work with a vendor prefix in webkit browsers (Chrome, Safari, etc.) and in Firefox only work with inline svg, instead of a link to an image. (http://caniuse.com/#feat=css-masks)

@ehgoodenough
Copy link
Member Author

Yeah, I think you're totally right. So we need to update the React entity to include the vendor-specific styles, not just the vanilla styles.

@ehgoodenough
Copy link
Member Author

Either that, or switch from CSS Masks to CSS Color Rotates, or do the stupid lazy thing and color the sprites by canvas.

@Willamin
Copy link
Contributor

My vote it to switch to the stupid lazy thing until Mozilla realizes it's 2016 and that they need to properly implement CSS masks. It looks like Webkit has had them since 2008 (https://webkit.org/blog/181/css-masks/). ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants